Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove VTK variants 8.1.2 #374

Closed
paskino opened this issue Jan 8, 2024 · 2 comments · Fixed by #375
Closed

remove VTK variants 8.1.2 #374

paskino opened this issue Jan 8, 2024 · 2 comments · Fixed by #375

Comments

@paskino
Copy link
Collaborator

paskino commented Jan 8, 2024

See TomographicImaging/iDVC#77

Basically with vtk9 the clipped cube source does not show up as it does on vtk8
@paskino
Copy link
Collaborator Author

paskino commented Jan 9, 2024

I posted on VTK's Discourse https://discourse.vtk.org/t/vtkpolydata-actor-behaviour-is-changed-in-vtk-9-1/13037

Minimal example to reproduce the error is in https://github.com/vais-ral/CILViewer/blob/cube_source/Wrappers/Python/examples/cubesource_clip.py

@paskino
Copy link
Collaborator Author

paskino commented Jan 10, 2024

The behaviour depends on a change of behaviour of VTK, see VTK Discourse.
With TomographicImaging/iDVC#216 the bug, which is not a viewer bug will be removed. So iDVC will be able to use VTK9 and in this repo we can remove the variants requiring VTK 8.1.2
https://github.com/vais-ral/CILViewer/blob/b811547112352124c1d7d7b668488efd706f36ef/Wrappers/Python/conda-recipe/conda_build_config.yaml#L8-L9

@paskino paskino changed the title PlaneClipper on vtk >8 does not work as expected on cube source remove VTK variants 8.1.2 Jan 12, 2024
paskino added a commit that referenced this issue Jan 12, 2024
@paskino
removed VTK8 variants
1afe8e6 
closes remove VTK variants 8.1.2 #374
@paskino paskino mentioned this issue Jan 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove vtk8 variants and updates Python variants TomographicImaging/CILViewer
1 participant
@paskino