Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove LinkedHashSet #85

Open
Tomboyo opened this issue Jul 23, 2023 · 0 comments
Open

Remove LinkedHashSet #85

Tomboyo opened this issue Jul 23, 2023 · 0 comments

Comments

@Tomboyo
Copy link
Owner

Tomboyo commented Jul 23, 2023

We use LinkedHashSet throughout the AST to ensure set iteration order is consistent between runs. This is a relic of older test strategies that are on the way out and which relied upon consistent encounter order to pass.

In cases where the name of an anonymous type is dependent upon its position in a list, the ordinal comes from the underlying OAS list and is therefore consistent between runs regardless of Set implementation used thereafter.

Remove LinkedHashSet in favor of Set, which is easier to work with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

1 participant