Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI pnpm Deprecated Node Version #30

Closed
1 task
TomChamberlainUK opened this issue Feb 4, 2024 · 1 comment · Fixed by #48
Closed
1 task

Fix CI pnpm Deprecated Node Version #30

TomChamberlainUK opened this issue Feb 4, 2024 · 1 comment · Fixed by #48
Assignees
@TomChamberlainUK
Labels
bug Something isn't working

Comments

@TomChamberlainUK
Copy link
Owner

Fix CI pnpm Deprecated Node Version

Fix deprecated Node version when installing pnpm on our CI

Description

Currently we're getting the following deprecation warnings about Node when installing pnpm on our CI:

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: pnpm/action-setup@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

As seen here:

Image

An issue has been raised addressing it which should be monitored:

Apparently this can be avoided by using corepack enable but ideally we'd use native pnpm Github actions

Done When

  • pnpm Node version updated to version 20
@TomChamberlainUK TomChamberlainUK added the bug Something isn't working label Feb 4, 2024
@TomChamberlainUK TomChamberlainUK self-assigned this Feb 21, 2024
@TomChamberlainUK TomChamberlainUK mentioned this issue Feb 21, 2024
Merged
@TomChamberlainUK TomChamberlainUK linked a pull request Feb 21, 2024 that will close this issue
#30 Fixed CI Deprecated Node Version Warning #48
Merged
@TomChamberlainUK
Copy link
Owner Author

Fixed and tested in this PR: #48

TomChamberlainUK added a commit that referenced this issue Feb 21, 2024
@TomChamberlainUK
#30 Fixed CI Deprecated Node Version Warning (#48)
c04981e 
Bumped pnpm action-setup version to v3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TomChamberlainUK TomChamberlainUK

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#30 Fixed CI Deprecated Node Version Warning TomChamberlainUK/music
1 participant
@TomChamberlainUK