-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to Gradle's "official" support for custom compilers #13
Comments
@TheMrMilchmann there is intention on the Gradle side to get the PR integrated. I'll address the comments there soon. In the meantime, I would appreciate your feedback to see if this also solves the general case, before it gets released. I was mostly testing it with one real project and a toy project. For obscure reasons 😄, I pushed a patched Gradle with the PR integrated here. Feel free to use that for testing (it's a full distribution in that folder): |
Thanks, @jjohannes! In my opinion, this is looking really good. My only concern with this approach is that it might restrict the JVM used to run the build to be compatible with the custom compiler. However, I'm not entirely sure that's the case. I'll look into this in detail and run some tests ASAP although probably not before tomorrow evening. |
It should pick the |
Note: Unfortunately, it looks like this didn't make the cut for 8.3. |
Unfortunately, gradle/gradle#24649 was dropped, and it seems like it might be a while before any official support is made available. However, the plugin is quite stable, so there is no urgency for me at the moment. I will reconsider creating an |
While it remains to be seen if this ends up being merged, gradle/gradle#24649 looks like a promising solution for custom compiler jars. It makes sense to test against this change to check if everything works as intended. Using a custom Gradle build should hopefully not be too tricky but might require some more work.
If this test succeeds and when the change is merged, I should finally be able to release a stable version of this plugin. 🥳
The text was updated successfully, but these errors were encountered: