Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for compiler participants ? #1

Closed
foreveremain opened this issue Jul 21, 2022 · 3 comments
Closed

add support for compiler participants ? #1

foreveremain opened this issue Jul 21, 2022 · 3 comments
Labels
a:feature New feature or request was:rejected This will not be worked on

Comments

@foreveremain
Copy link

Thanks so much for creating this new ecj plugin ! Do you think there's a possibility to allow execution of ecj compiler participants ? These are normally bundled as regular eclipse plugins, and the one I'm familiar with is https://github.com/java2script/java2script/ - which transpiles Java code to .js files, allowing Java swing apps to run in the browser (I develop this one: https://www.jalview.org/jalview-js/JalviewJS.shtml but the plugin's main developer is @BobHanson, who also develops https://chemapps.stolaf.edu/jmol/jsmol/jsmol.htm ).

@TheMrMilchmann TheMrMilchmann added the a:feature New feature or request label Jul 21, 2022
@TheMrMilchmann
Copy link
Owner

Hi! I've taken a brief look at Eclipse JDT's compilation participants but I'm not sure what is required to set them up. This plugin is invoking ECJ via its command line interface and all I can find are docs about how to set it up programmatically. This is something I am not willing to change since a programmatic solution would require using a lot of unstable Gradle internals.

Also note that if it's possible to add participants via CLI, you should already be able to do that by modifying the freeCompilerArgs of the JavaCompile task. It is possible that I'm misunderstanding something, so if you have more information, please let me know.

@TheMrMilchmann TheMrMilchmann added the is:awaiting-response Waiting for reporter/contributer to comment label Jul 26, 2022
@TheMrMilchmann TheMrMilchmann added was:rejected This will not be worked on and removed is:awaiting-response Waiting for reporter/contributer to comment labels Feb 23, 2023
@TheMrMilchmann
Copy link
Owner

Due to the lack of follow-up and the reasons stated above, this will not be worked on for now. I might revisit this at some point if Gradle opens up the API for custom Java compilers.

@TheMrMilchmann TheMrMilchmann closed this as not planned Won't fix, can't repro, duplicate, stale Feb 23, 2023
@foreveremain
Copy link
Author

Nice to see some activity here. The news that gradle 8 might not support ecj meant I didn't pursue this further - and somehow I missed your july 21 comment about freeCompilerArgs. We're still working with the java2script compiler participant - perhaps I'll find some time to experiment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:feature New feature or request was:rejected This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants