Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searching While Awaiting Geolocation Feature #302

Open
someyoungideas opened this issue Mar 28, 2018 · 3 comments
Open

Searching While Awaiting Geolocation Feature #302

someyoungideas opened this issue Mar 28, 2018 · 3 comments
Assignees
Labels
enhancement New feature or request frontend help wanted Extra attention is needed

Comments

@someyoungideas
Copy link
Contributor

As I a user viewing the application for the first time I should have some visual notification that I have either denied geolocation, or that my geolocation is currently in process. Along with this visual notification I should also be allowed to use the search effectively. Currently if you have blocked geolocation or in the process of getting your current position the search is broken and is throwing errors due to userPosition not being set in the home route state.

@jkwening jkwening added enhancement New feature or request help wanted Extra attention is needed frontend labels Mar 28, 2018
@jkwening
Copy link
Contributor

@someyoungideas great summary of the issue - I'll assign to you if you want to work on this issue.

Here's a useful reference doc for navigation.geolocation: https://developer.mozilla.org/en-US/docs/Web/API/Geolocation/Using_geolocation

@someyoungideas
Copy link
Contributor Author

@jkwening I would be glad to take this issue. I may have some questions along the way. Would you like me to just post them in here and mention you as they come up, would there be a more preferred place?

@jkwening
Copy link
Contributor

@someyoungideas assigned to you. Yeah, just post in here and mention me as they come up. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants