Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup Unit Test Coverage Reports for Deno Packages #63

Open
tgadam opened this issue Jul 1, 2022 · 10 comments
Open

Setup Unit Test Coverage Reports for Deno Packages #63

tgadam opened this issue Jul 1, 2022 · 10 comments
Assignees

Comments

@tgadam
Copy link
Contributor

tgadam commented Jul 1, 2022

Setup Unit Test Coverage Reports for Deno Packages and hook it up to CodeCov for OpenSource using GitHub Actions.

@tgadam
Copy link
Contributor Author

tgadam commented Jul 12, 2022

@tnrich I think you've setup CodeCov for OVE... can you help us get unit tests and coverage setup for the FSML code?

@tgadam
Copy link
Contributor Author

tgadam commented Jul 19, 2022

@tnrich were you able to get this working?

@tnrich
Copy link
Contributor

tnrich commented Jul 21, 2022

@tgadam nope, not able to get this working

The deno coverage command doesn't seem to be working quite yet..
I tried to troubleshoot it and couldn't run through deno's official example so I made an issue in the linked example repo - oakserver/oak#539

Seems like deno is still a bit immature at this point.

@tnrich
Copy link
Contributor

tnrich commented Jul 21, 2022

@tgadam oh, looks like someone got back to me on the example! I'll work through the example and see if that gets me unblocked.

@tnrich
Copy link
Contributor

tnrich commented Jul 28, 2022

@tgadam I was able to get the coverage generating properly for the oak repo but for some reason running the same commands locally does not seem to work.. not sure what is going wrong..

@tgadam
Copy link
Contributor Author

tgadam commented Jul 29, 2022

@tnrich I noticed the oak example uses import maps. I was planning on moving us to using import maps but hadn't done it yet. Maybe that's part of what we need to do?

@tnrich
Copy link
Contributor

tnrich commented Jul 29, 2022

@tgadam potentially? Not sure why that would be necessary but I suppose it might be

@tnrich
Copy link
Contributor

tnrich commented Aug 1, 2022

@tgadam I tried fiddling with the import-map and was unable to get coverage working with that either.. Not sure what the issue is here.

@tnrich
Copy link
Contributor

tnrich commented Aug 1, 2022

Lol looking more closely reveals that we're not actually importing any src files into our test. That might be at the source of this 😆

@eabeliuk
Copy link
Contributor

eabeliuk commented Aug 5, 2022

It seems that this was covered in #87. I'm moving this to "merged".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants