Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: No way to set 'import-from' parameter since 3.0.1-rc2 #1236

Open
TomyLobo opened this issue Jan 31, 2025 · 3 comments
Open

regression: No way to set 'import-from' parameter since 3.0.1-rc2 #1236

TomyLobo opened this issue Jan 31, 2025 · 3 comments
Labels
issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change proposal/pending The proposal still has to be reviewed type/feature Completely new functionality type/upstream This is an issue in one of our dependencies and should be reported there

Comments

@TomyLobo
Copy link

TomyLobo commented Jan 31, 2025

#606 introduced an import_from parameter to disks, which added the import-form parameter to, for instance, the --scsi[n] option.
This was removed in 5b89c2e#diff-104365919f693375882979581d9f36f5266991eef361948e56c220931fe886ddL600 and never re-added.

Is it possible to add this back?
It's really useful in order to import official disk images.

@Tinyblargon Tinyblargon added type/upstream This is an issue in one of our dependencies and should be reported there issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change type/feature Completely new functionality proposal/pending The proposal still has to be reviewed labels Jan 31, 2025
@Tinyblargon
Copy link
Collaborator

@TomyLobo agree that we should at it back, but not sure yet about it's exact behavior and implementation. Pretty sure we need to add support for this in the upstream SDK.

@TomyLobo
Copy link
Author

TomyLobo commented Feb 3, 2025

@Tinyblargon isn't it just another parameter in the disk dictionary?
This test case looks like it, at least:
https://github.com/Telmate/proxmox-api-go/blob/master/test/api/CloudInit/cloudinit_test.go#L28

@Tinyblargon
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change proposal/pending The proposal still has to be reviewed type/feature Completely new functionality type/upstream This is an issue in one of our dependencies and should be reported there
Projects
None yet
Development

No branches or pull requests

2 participants