Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid CPU settings are not prevented #1232

Open
perlfisch opened this issue Jan 28, 2025 · 1 comment
Open

Invalid CPU settings are not prevented #1232

perlfisch opened this issue Jan 28, 2025 · 1 comment
Labels
issue/investigate type/bug type/upstream This is an issue in one of our dependencies and should be reported there

Comments

@perlfisch
Copy link

When editing the CPU settings of a VM, both the cores attached and the vCPUs actually usable can be configured independently of each other. The Web UI prevents setting the vCPUs to a greater value than cores * sockets, but seemingly neither the API nor this provider does so.

For example a configuration like the following deploys fine, but actually results in a broken, unbootable VM, which won't even tell you what the problem is:

resource "proxmox_vm_qemu" "this" {

  cores   = 24
  vcpus   = 32

Instead, a check in the provider should prevent configurations in which vcpus is greater than sockets * cores

@Tinyblargon
Copy link
Collaborator

@perlfisch Which version of the provider are you using?

I am a little confused as this situation gets explicitly tested upstream
https://github.com/Telmate/proxmox-api-go/blob/master/proxmox%2Fconfig_qemu_cpu_test.go#L204-L209

@Tinyblargon Tinyblargon added type/bug issue/investigate type/upstream This is an issue in one of our dependencies and should be reported there labels Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue/investigate type/bug type/upstream This is an issue in one of our dependencies and should be reported there
Projects
None yet
Development

No branches or pull requests

2 participants