Improving test coverage of parts of the API used by Terraform

[rf152]

I figured it's worth having an issue to capture the progress of the tests written

General Access

• User/Password authentication
• User/Api Token authentication

Qemu VM

• Create
• Read
• Update
• Delete
• Cloud-init

LXC Container

• Create
• Read
• Update
• Delete

Pool

• Create
• Read
• Update
• Delete

[rf152]

PR #245 Contains a fair number of tests.

I've also got a branch that I'm currently writing that adds the ability to interact with API tokens (although not their permissions at the moment), which opens up the ability to test the login with API tokens.

As to the LXC containers I've hit a bit of a wall because there is currently no method for importing / downloading templates via the go api, so that needs writing first. I'm hesitant to write the function before the layout has been fully planned (currently being discussed in #210), so I'm at a bit of an impasse.

One option may be to write a quick and dirty hack to get a template downloaded so that I can write tests for the LXC stuff, which should then get us most of the coverage for testing the parts that are used by the Terraform API

[mleone87]

nice! feel free to notify me when it's ready to merge!

[rf152]

@mleone87 that's as much as I can do at the moment, until we have a method for importing LXC containers, so I think it makes sense to merge #245, and I'll do another pull request when I've written a hack for importing LXC containers

[rf152]

Cloud-init now sorted in #258

Think this puts us in a good position to start refactoring the whole application