Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why hide doc for from_variants::FromVariants? #12

Open
andylokandy opened this issue Sep 25, 2024 · 1 comment
Open

Why hide doc for from_variants::FromVariants? #12

andylokandy opened this issue Sep 25, 2024 · 1 comment

Comments

@andylokandy
Copy link

andylokandy commented Sep 25, 2024 •
edited
Loading

The #[doc(hidden)] prevents rust-analyzer from auto importing the proc macro.
@TedDriggs
Copy link
Owner

I think it was because I didn't want it to show up in the docs for from_variant_impl.

  1. If you can make it show up in from_variants and not in from_variants_impl, then I will happily accept that PR.
  2. If you can grab some screenshots demonstrating that rust-analyzer will auto-import from from_variants and not from_variants_impl when you remove the #[doc(hidden)] then I would also accept that PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TedDriggs @andylokandy