From d71231586b6cc7ee00dc2be7d79a03066f2e52e6 Mon Sep 17 00:00:00 2001 From: kseysh Date: Wed, 19 Jun 2024 04:06:48 +0900 Subject: [PATCH] =?UTF-8?q?refactor=20-=20#122=20=EA=B0=80=EB=8F=85?= =?UTF-8?q?=EC=84=B1=EC=9D=84=20=EC=9C=84=ED=95=9C=20=EB=84=A4=EC=9D=B4?= =?UTF-8?q?=EB=B0=8D=20=EB=B3=80=EA=B2=BD?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../java/sopt/org/hmh/domain/auth/service/AuthFacade.java | 1 - .../hmh/domain/challenge/controller/ChallengeController.java | 4 ++-- .../org/hmh/domain/challenge/service/ChallengeFacade.java | 4 ++-- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/main/java/sopt/org/hmh/domain/auth/service/AuthFacade.java b/src/main/java/sopt/org/hmh/domain/auth/service/AuthFacade.java index c4bcbab0..fbc2725a 100644 --- a/src/main/java/sopt/org/hmh/domain/auth/service/AuthFacade.java +++ b/src/main/java/sopt/org/hmh/domain/auth/service/AuthFacade.java @@ -26,7 +26,6 @@ public class AuthFacade { private final KakaoLoginService kakaoLoginService; private final AppleOAuthProvider appleOAuthProvider; - private final ChallengeFacade challengeFacade; private final ChallengeAppService challengeAppService; private final TokenService tokenService; diff --git a/src/main/java/sopt/org/hmh/domain/challenge/controller/ChallengeController.java b/src/main/java/sopt/org/hmh/domain/challenge/controller/ChallengeController.java index a640249b..6dd9f363 100644 --- a/src/main/java/sopt/org/hmh/domain/challenge/controller/ChallengeController.java +++ b/src/main/java/sopt/org/hmh/domain/challenge/controller/ChallengeController.java @@ -60,7 +60,7 @@ public ResponseEntity> orderGetDailyChallen public ResponseEntity> orderAddApps(@UserId final Long userId, @RequestHeader("OS") final String os, @RequestBody @Valid final ChallengeAppArrayRequest requests) { - challengeFacade.addApps(userId, requests.apps(), os); + challengeFacade.addAppsToCurrentChallenge(userId, requests.apps(), os); return ResponseEntity .status(AppSuccess.ADD_APP_SUCCESS.getHttpStatus()) @@ -73,7 +73,7 @@ public ResponseEntity> orderAddApps(@UserId final Long userId, public ResponseEntity> orderRemoveApp(@UserId final Long userId, @RequestHeader("OS") final String os, @RequestBody @Valid final AppRemoveRequest request) { - challengeFacade.removeApp(userId, request.appCode(), os); + challengeFacade.removeAppFromCurrentChallenge(userId, request.appCode(), os); return ResponseEntity .status(AppSuccess.REMOVE_APP_SUCCESS.getHttpStatus()) diff --git a/src/main/java/sopt/org/hmh/domain/challenge/service/ChallengeFacade.java b/src/main/java/sopt/org/hmh/domain/challenge/service/ChallengeFacade.java index cbe31915..f49bbbc7 100644 --- a/src/main/java/sopt/org/hmh/domain/challenge/service/ChallengeFacade.java +++ b/src/main/java/sopt/org/hmh/domain/challenge/service/ChallengeFacade.java @@ -95,13 +95,13 @@ private Integer calculateTodayIndex(LocalDateTime challengeCreateAt, int period) } @Transactional - public void addApps(Long userId, List requests, String os) { + public void addAppsToCurrentChallenge(Long userId, List requests, String os) { Challenge challenge = this.findCurrentChallengeByUserId(userId); challengeAppService.addApps(challenge, requests, os); } @Transactional - public void removeApp(Long userId, String appCode, String os) { + public void removeAppFromCurrentChallenge(Long userId, String appCode, String os) { Challenge challenge = this.findCurrentChallengeByUserId(userId); challengeAppService.removeApp(challenge, appCode, os); }