Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert rate limit #2943

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Revert rate limit #2943

wants to merge 2 commits into from

Conversation

kstdl
Copy link
Contributor

@kstdl kstdl commented Jan 30, 2025

Purpose

How does the solution address the problem

Changes made

@kstdl kstdl force-pushed the revert_rate_limit branch from 9cc109f to 3a05fbd Compare January 30, 2025 16:19
Copy link
Contributor

@mfrankovi mfrankovi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this will help. Reducing threads maybe but removing the max_pending_tasks limiter will in my opinion only queue the request, increase the memory and crash the node. Without some kind of external limiter I would not recommend removing this internal one.

@kstdl kstdl force-pushed the revert_rate_limit branch from 3a05fbd to fe3b2f4 Compare January 31, 2025 08:45
Copy link
Contributor

@mfrankovi mfrankovi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine if we for instance change the limit from 100 to 1000. I just would not remove it completely because this would kill the node when we are too slow to process requests or there are too many of them

@kstdl
Copy link
Contributor Author

kstdl commented Jan 31, 2025

@mfrankovi this isn't making anything better. As we saw yesterday RPC nodes were running out of memory with this limit. But it is messing with apps where we were seeing alot of random disconnects because there was like 1 long request some quick ones. Rate limiting could be implemented separately on the load balancer layer, but I don't think it should be part of the node.
If you want to keep this you can just create a separate PR with config changes and get approves from @MatusKysel @JakubFornadel and @rattrap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants