Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tabby-agent: User agent string containing newlines causes failed healthchecks #3648

Open
ProjectFrank opened this issue Jan 6, 2025 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@ProjectFrank
Copy link

Describe the bug
When using emacs , the error below is raised causing healthchecks to fail.

Information about your version
tabby-agent version 1.8.0

Information about your GPU
Not relevant

Additional context

Logs:

{"level":20,"time":1736183692724,"pid":32410,"hostname":"MacBook-Pro-4.local","tag":"TabbyApiClient","msg":"Health check request: GET http://localhost:8082/v1/health. [6dde18a5-d70a-4ad3-a354-a71bb010dde1]"}
{"level":50,"time":1736183692724,"pid":32410,"hostname":"MacBook-Pro-4.local","tag":"TabbyApiClient","error":{"type":"TypeError","message":"Headers.set: \"Node.js/v20.9.0 tabby-agent/1.8.0 emacs/GNU Emacs 29.1 (build 1, aarch64-apple-darwin21.6.0, Carbon Version 165 AppKit 2113.6)\n of 2023-09-26\" is an invalid header value.","stack":"TypeError: Headers.set: \"Node.js/v20.9.0 tabby-agent/1.8.0 emacs/GNU Emacs 29.1 (build 1, aarch64-apple-darwin21.6.0, Carbon Version 165 AppKit 2113.6)\n of 2023-09-26\" is an invalid header value.\n    at webidl.errors.exception (node:internal/deps/undici/undici:1432:14)\n    at webidl.errors.invalidArgument (node:internal/deps/undici/undici:1443:28)\n    at _Headers.set (node:internal/deps/undici/undici:2016:31)\n    at Hxe (/Users/work/.nvm/versions/node/v20.9.0/lib/node_modules/tabby-agent/dist/node/index.js:381:2913)\n    at o (/Users/work/.nvm/versions/node/v20.9.0/lib/node_modules/tabby-agent/dist/node/index.js:381:1317)\n    at Object.GET (/Users/work/.nvm/versions/node/v20.9.0/lib/node_modules/tabby-agent/dist/node/index.js:381:1875)\n    at JB.healthCheck (/Users/work/.nvm/versions/node/v20.9.0/lib/node_modules/tabby-agent/dist/node/index.js:387:1278)\n    at JB.connect (/Users/work/.nvm/versions/node/v20.9.0/lib/node_modules/tabby-agent/dist/node/index.js:387:527)\n    at Timeout._onTimeout (/Users/work/.nvm/versions/node/v20.9.0/lib/node_modules/tabby-agent/dist/node/index.js:386:2348)\n    at listOnTimeout (node:internal/timers:573:17)"},"msg":"Health check request failed. [6dde18a5-d70a-4ad3-a354-a71bb010dde1]"}
@icycodes
Copy link
Member

icycodes commented Jan 7, 2025

Hi @ProjectFrank,
Thank you for reporting this bug.
I will fix it in the next release.

@icycodes icycodes added bug Something isn't working and removed bug-unconfirmed labels Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants