Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we need to support Python 3.7 for EduBot? #25

Open
skilkis opened this issue Apr 29, 2020 · 3 comments
Open

Do we need to support Python 3.7 for EduBot? #25

skilkis opened this issue Apr 29, 2020 · 3 comments

Comments

@skilkis
Copy link
Contributor

skilkis commented Apr 29, 2020

If not, then GitHub actions can stop running tests on Python 3.7 and setup.cfg can be updated to require Python 3.8.

@jooste
Copy link
Member

jooste commented Apr 29, 2020

Well, I run the bot with py3.7 at the moment. Can you see why the unit test succeeds with py38 but not py37?

@skilkis
Copy link
Contributor Author

skilkis commented Apr 29, 2020

It stems from an error raised in tests/helpers.py since unittest.mock.AsyncMock was introduced in Python 3.8. Unfortunately, we will need that if we wish to do unit-tests on our bot.

https://github.com/TUDelft-CNS-ATM/EduBot/runs/629113583?check_suite_focus=true#step:6:128

@jooste
Copy link
Member

jooste commented Apr 29, 2020

Ahh, ok. Well, just leave it be then. Nothing we can do to fix this, even though we know that the bot runs fine on py37!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants