Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image Denotation for Mantis-Idefics2 #24

Open
schwarzwalder93 opened this issue Feb 11, 2025 · 1 comment
Open

Image Denotation for Mantis-Idefics2 #24

schwarzwalder93 opened this issue Feb 11, 2025 · 1 comment

Comments

@schwarzwalder93
Copy link

schwarzwalder93 commented Feb 11, 2025

Hi Team,

Thanks for this amazing work. In the Mantis paper, the importance of image denotation with numbering and ordering is highlighted as below:

"Interleaving Text-Image: A proper text-image interleaving format can help acquire multi-image understanding and reasoning ability. We contend that a good text-image interleaving format should: (1) mark boundaries between images clearly, and (2) denote the serial number of images. Following this principle, we designed our interleaving format as follows: "(image {i}: <BOI><image><EOI>)", where <BOI> is the begin of image token and <EOI> is the end of image token. <image> is the placeholder for image patches. This format adds clear separators between images, and gives serialized information of the image through "image {i}". In practice, we set <BOI> and <EOI> to be and respectively"

However, I am unable to find such serial number based denotation in the processed prompt for Mantis-idefics2:

'<s> User:<fake_token_around_image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><fake_token_around_image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><fake_token_around_image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><image><fake_token_around_image> What cities image 1, image 2, and image 3 belong to respectively? Answer me in order.<end_of_utterance> \nAssistant:'

Kindly clarify this understanding.

@jdf-prog
Copy link
Collaborator

Since Idefics2 is already a well-trained model, we did not add those image denotations like during the training. Actualy , Idefics2 has <fake_token_around_image> which can serve as the same tole

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants