Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong aspect_ratio param in llava-onevision evaluation #5

Open
Luodian opened this issue Dec 16, 2024 · 2 comments
Open

Wrong aspect_ratio param in llava-onevision evaluation #5

Luodian opened this issue Dec 16, 2024 · 2 comments

Comments

@Luodian
Copy link

Luodian commented Dec 16, 2024

I think the param is not set correctly.

overwrite_config["image_aspect_ratio"] = "pad"

It should be "anyrex_max_9" or directly read from the config.json

@woodfrog
Copy link
Collaborator

We followed your official tutorial for multi-image interleaved input. See the section of Image-Text Interleaved Input.

Do you have thoughts/insights on how this parameter setting would affect the performance? We can run again with anyrex_max_9 if the one in the tutorial is not the optimal setting.

@woodfrog
Copy link
Collaborator

I checked your git history. That padding config was introduced by this commit with the commit message "Fix tutorial error", so it seems to be an intentional change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants