Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reassociate timed triggers after instrument resets #13

Open
amcmahon01 opened this issue Jul 30, 2018 · 0 comments
Open

Reassociate timed triggers after instrument resets #13

amcmahon01 opened this issue Jul 30, 2018 · 0 comments

Comments

@amcmahon01
Copy link
Member

Description

Currently, if a timed trigger is running and an instrument is reset, the timer continues running and as a result the old instrument object continues to exist since there is still an active reference to it. This results in both instrument objects attempting to run simultaneously and the original timed trigger cannot be stopped.

Possible Implementation

Timed trigger objects should be stopped and destroyed during instrument reset so that the instrument object can be properly destroyed without lingering references. Optionally, the status of the timer (running or not) could be transferred to the new object, but given that some instruments need manual initialization, this is probably best done manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants