Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

S1/#625 fix order api #627

Merged
merged 2 commits into from
Feb 27, 2024
Merged

S1/#625 fix order api #627

merged 2 commits into from
Feb 27, 2024

Conversation

gunom
Copy link
Contributor

@gunom gunom commented Feb 27, 2024

๐Ÿ”ฅ Related Issues

resolved #625

๐Ÿ’œ ์ž‘์—… ๋‚ด์šฉ

  • ๋ฌดํ†ต์žฅ ์ž…๊ธˆ x ๋ฒ„ํŠผ ๋ชจ๋‹ฌ ์—ฐ๊ฒฐ
  • ๊ตฌ๋งคํ•˜๊ธฐ api ๊ตฌ๋งคํ•˜๊ธฐ ๋ฒ„ํŠผ -> ๋ชจ๋‹ฌ๋กœ ๋ณ€๊ฒฝ

โœ… PR Point

  • ๋ฌด์Šจ ์ด์œ ๋กœ ์–ด๋–ป๊ฒŒ ์ฝ”๋“œ๋ฅผ ๋ณ€๊ฒฝํ–ˆ๋Š”์ง€
  • ์–ด๋–ค ์œ„ํ—˜์ด๋‚˜ ์šฐ๋ ค๊ฐ€ ๋ฐœ๊ฒฌ๋˜์—ˆ๋Š”์ง€
  • ์–ด๋–ค ๋ถ€๋ถ„์— ๋ฆฌ๋ทฐ์–ด๊ฐ€ ์ง‘์ค‘ํ•ด์•ผ ํ•˜๋Š”์ง€

๐Ÿ˜ก Trouble Shooting

  • ์–ด๋–ค ์–ด๋ ค์›€์ด ์žˆ์—ˆ๊ณ  ์–ด๋–ป๊ฒŒ ํ•ด๊ฒฐํ–ˆ๋Š”์ง€

โ˜€๏ธ ์Šคํฌ๋ฆฐ์ƒท / GIF / ํ™”๋ฉด ๋…นํ™”

๐Ÿ“š Reference

  • ๊ตฌํ˜„์— ์ฐธ๊ณ ํ•œ ๋งํฌ (ํ•„์š”ํ•œ ๊ฒฝ์šฐ๋งŒ ์ž‘์„ฑํ•˜๊ณ  ์—†์œผ๋ฉด ์ง€์šฐ๊ธฐ)

@gunom gunom self-assigned this Feb 27, 2024
@gunom gunom changed the base branch from main to develop February 27, 2024 14:22
@gunom gunom merged commit 996bdd3 into develop Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yeonseo-Jo Yeonseo-Jo Yeonseo-Jo approved these changes

@Arooming Arooming Awaiting requested review from Arooming

@lydiacho lydiacho Awaiting requested review from lydiacho

@urjimyu urjimyu Awaiting requested review from urjimyu

Assignees

@gunom gunom

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[S1/OrderDepositPage] ๊ตฌ๋งค ์š”์ฒญ api ๋ชจ๋‹ฌ๋กœ ๋ณ€๊ฒฝ
2 participants
@gunom @Yeonseo-Jo