-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for multi-threaded FFTW operations. #11
Comments
Starting to dig into this. Relevant issues from fftw3 Issue for the thread callback model, lots of useful info: |
To quote that last thread:
|
It seems that work got released as part of 3.3.10: With this in mind, I need to do
|
Update FFTW3 version: |
The bindings currently handle plan thread safety exactly the way I want:
|
Working on the rayon callback, hitting a snag with Rust ptrs not being Sync + Send: There is a crate to handle this issue: |
Got the rayon callback compiled and setup a simple test, running into a linking issue, I think I forgot to link the threads library.
|
Oh and I had to set |
I think the rayon thread callback is working now. An interesting note there, I had to double check how building FFTW3 works again, and you need to configure and build |
Initial threading PR for fftw bindings: |
This is complete for our purposes. I need to do some cleanup on the feature in the bindings, but I'll deal with that over there. |
This issue has two parts.
First, we need to implement the changes from:
rust-math/fftw#127
in our fork of the FFTW3 bindings:
https://github.com/SallySoul/fftw3-rs
Second, we need to add support for using the Rayon thread pool with FFTW3.
This involves exposing
fftw_threads_set_callback
, as described hereSecond we need to setup an actual callback function that utilizes rayon.
The text was updated successfully, but these errors were encountered: