Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.12.2-6.1.0] Empty strings are replaced with "==" #117

Open
aaronhowser1 opened this issue Aug 22, 2020 · 3 comments
Open

[1.12.2-6.1.0] Empty strings are replaced with "==" #117

aaronhowser1 opened this issue Aug 22, 2020 · 3 comments

Comments

@aaronhowser1
Copy link

Problem Details

When using Metal Chests, any mod that has an empty string is replaced with "=="
This is because of this line in the en_us.lang.
This was explicitly pointed out in #107, which you then closed without fixing, for some reason? This is explicitly the fault of Metal Chests, quat literally found the line in the mod's source code that causes this.

Screenshots


Environment

  • OS: W10
  • Full Forge version: Minecraft 1.12.2, Forge 14.23.5.2847
  • Mod version: MetalChests-v6.1.0+mc1.12.2
@aaronhowser1
Copy link
Author

Removing MC fixes it, adding it back brings the issue back

@aaronhowser1
Copy link
Author

aaronhowser1 commented Aug 22, 2020

For modpack devs that find this if it's not fixed, a single = line with Resource Loader fixes it
image

@aaronhowser1
Copy link
Author

Oh, looks like it was fixed? But it was just never pushed to CF?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant