Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

time frame handling in listmode reconstruction #1249

Closed
KrisThielemans opened this issue May 9, 2024 · 3 comments
Closed

time frame handling in listmode reconstruction #1249

KrisThielemans opened this issue May 9, 2024 · 3 comments

Comments

@KrisThielemans
Copy link
Member

  • We do not have a set_time_interval yet for the list-mode objective function. It looks like this can be done in STIR by taking the objective function and setting its (public) frame_defs member. See also listmode reconstruction and time frame: missing set functions UCL/STIR#1417
  • Our demo sets a time interval for the creation of the scatter etc here, but as listmode reconstruction will be using all events, there is going to be a mismatch, so this is a bug.

@evgueni-ovtchinnikov easy to add a set_time_interval method to the listmode objective function?

@evgueni-ovtchinnikov
Copy link
Contributor

I understand it is not in STIR yet? Once you make it available in STIR, should not be difficult to access it from SIRF.

@KrisThielemans
Copy link
Member Author

It doesn't need STIR modifications luckily.

Essentially a copy of ListmodeToSinograms::set_time_interval, i.e. adding set_time_interval to xSTIR_PoissonLLhLinModMeanListDataProjMatBin3DF (as [here](e.g.

void set_time_interval(double start, double stop)
{
std::pair<double, double> interval(start, stop);
std::vector < std::pair<double, double> > intervals;
intervals.push_back(interval);
frame_defs = stir::TimeFrameDefinitions(intervals);
do_time_frame = true;
}
)) and exposing it in exactly the same way

@evgueni-ovtchinnikov
Copy link
Contributor

fixed by #1253

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants