Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

old MR notebooks have multiple problems #29

Closed
KrisThielemans opened this issue May 12, 2019 · 3 comments
Closed

old MR notebooks have multiple problems #29

KrisThielemans opened this issue May 12, 2019 · 3 comments
Milestone

Comments

@KrisThielemans
Copy link
Member

KrisThielemans commented May 12, 2019

The older notebooks (not those in the interactive folder) were stripped too much and we get an error when opening them (see the process in #20).

They also need changing of petmr_data_path(...) with examples_data_path('MR').

However, I suspect that the notebooks in https://github.com/CCPPETMR/SIRF-Exercises/tree/master/notebooks/MR shouldn't really be there anymore and are superseded by those in interactive. @ckolbPTB @johannesmayer @DANAJK could you confirm that these are safe too delete?

I'm not sure what to do with those in tools. acqh5info might contain things that are now elsewhere. im5info uses h5py and seems interesting (but could do with some more info). @DANAJK, do we keep these ?

@KrisThielemans KrisThielemans added this to the v2.0 milestone May 12, 2019
@paskino
Copy link
Contributor

paskino commented May 14, 2019

I was in the process of testing the notebooks.
I fixed the notebooks in MR #30

Except from this the others seem to work.

@KrisThielemans
Copy link
Member Author

what's the problem with the remaining one?

@KrisThielemans
Copy link
Member Author

I've created a separate issue for the remaining problem. #31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants