Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Allow custom root_sass to be relative paths #8

Closed
weaverryan opened this issue Aug 30, 2023 · 2 comments
Closed

Fix: Allow custom root_sass to be relative paths #8

weaverryan opened this issue Aug 30, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@weaverryan
Copy link
Contributor

See: SymfonyCasts/tailwind-bundle#22

Also, this option is undocumented and should be documented.

AND, if the user just does:

root_sass: 'assets/styles/foo.scss'

We should normalize that into an array for them
@weaverryan
Copy link
Contributor Author

I just tripped over this in my own project, lol.

For SassBundle, we also need to be careful that the compiler is adjusted. IIrc, I COULD sass:build just fine with a relative path. But the path comparison in supports() of the compiler failed with a relative path.

@weaverryan weaverryan added the bug Something isn't working label Oct 27, 2023
@wryk wryk mentioned this issue Feb 19, 2024
Closed
wryk added a commit to wryk/sass-bundle that referenced this issue Feb 23, 2024
@wryk
Fix root_sass relative paths (SymfonyCasts#8 SymfonyCasts#43)
0304688
bocharsky-bw pushed a commit that referenced this issue Feb 26, 2024
@wryk
Fix root_sass relative paths (#8 #43) (#64)
aa47da8
@bocharsky-bw
Copy link
Member

Closed with #64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@weaverryan @bocharsky-bw