Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENOENT errors from non-existent directories #193

Open
djc opened this issue Mar 5, 2024 · 3 comments
Open

ENOENT errors from non-existent directories #193

djc opened this issue Mar 5, 2024 · 3 comments

Comments

@djc
Copy link

djc commented Mar 5, 2024

I've recently been seeing some errors from using rust-cache (in Askama):

Screenshot 2024-03-05 at 12 16 30

This should be a bog-standard setup:

Screenshot 2024-03-05 at 12 16 55
@Swatinem
Copy link
Owner

Swatinem commented Mar 6, 2024

I believe a similar issue was already reported at some point.

All the file system operations are behind try/catch, so they do not interfere with the correct operation.
However I see the point that they are spamming errors onto the build output :-(

@djc
Copy link
Author

djc commented Mar 6, 2024

I'm not sure why it's even trying to remove askama/askama/target/tests/target? Seems very unlikely to exist in the first place, given that askama is where that target dir lives (in the workspace).

@sl4m
Copy link

sl4m commented Jun 6, 2024

I'm not sure why it's even trying to remove askama/askama/target/tests/target? Seems very unlikely to exist in the first place, given that askama is where that target dir lives (in the workspace).

I believe it's due to the clean-up step attempting to explicitly clean-up the target directory along with trybuild.

try {
// https://github.com/vertexclique/kaos/blob/9876f6c890339741cc5be4b7cb9df72baa5a6d79/src/cargo.rs#L25
// https://github.com/eupn/macrotest/blob/c4151a5f9f545942f4971980b5d264ebcd0b1d11/src/cargo.rs#L27
cleanTargetDir(path.join(profileDir, "target"), packages, checkTimestamp);
} catch { }
try {
// https://github.com/dtolnay/trybuild/blob/eec8ca6cb9b8f53d0caf1aa499d99df52cae8b40/src/cargo.rs#L50
cleanTargetDir(path.join(profileDir, "trybuild"), packages, checkTimestamp);
} catch { }

@Swatinem I had a look at the links you provided in the comments and none of the projects use rust-cache actions. Would it be better to remove these lines rather than to support the few that might have this setup?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants