Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RNPM for RN 0.60+ #56

Open
kidx5452 opened this issue Aug 15, 2019 · 17 comments
Open

Update RNPM for RN 0.60+ #56

kidx5452 opened this issue Aug 15, 2019 · 17 comments

Comments

@kidx5452
Copy link

Project need add file react-native.config.js to update "rnpm" props in packages.json.

@TheChanDI
Copy link

yeahh.. i am not being able to use this library because of RN 0.60+. Please update 'rnpm' props in packages.json

@janczizikow
Copy link
Contributor

@Sunhat would it be possible to release new version of the package to the npm?

@andreifilip123
Copy link

Any upcoming release ? Or we should use the master branch ?

@iamandiradu
Copy link

Release?

2 similar comments
@nathantaal
Copy link

Release?

@christheyounger
Copy link

Release?

@a-tokyo
Copy link

a-tokyo commented Feb 4, 2020

Can you please Release? 💪

@Sunhat
Copy link
Owner

Sunhat commented Mar 5, 2020

Dead project. Nobody should use this.

@rafalolszewski94
Copy link

@Sunhat any recommendations on alternatives?

@ziyaddin
Copy link

@rafalolszewski94 have you found any alternatives?

@a-tokyo
Copy link

a-tokyo commented Aug 11, 2020

@ziyaddin I use this for now https://github.com/pluralcom/react-native-extra-dimensions-android

{
    "react-native-extra-dimensions-android": "https://github.com/pluralcom/react-native-extra-dimensions-android",
}

@Sunhat
Copy link
Owner

Sunhat commented Aug 13, 2020

If Airbnb do not need this, then I'm going to say nobody else does either

@Sunhat
Copy link
Owner

Sunhat commented Aug 13, 2020

Please provide me with an argument as to why this is necessary?

@a-tokyo
Copy link

a-tokyo commented Aug 13, 2020

Example usecase:

  if (Platform.OS === 'android') {
    const ExtraDimensions = require('react-native-extra-dimensions-android');
    const STATUSBAR_HEIGHT = ExtraDimensions.get('STATUS_BAR_HEIGHT');
    const WINDOW_HEIGHT =
      ExtraDimensions.get('REAL_WINDOW_HEIGHT') -
      STATUSBAR_HEIGHT -
      ExtraDimensions.get('SOFT_MENU_BAR_HEIGHT');
    return { STATUSBAR_HEIGHT, WINDOW_HEIGHT };
  }

NOTE: Different existing RN projects ALREADY use this repo, which means that upgrading RN would be an issue just because of RNPM issues that can be maintained.

@christheyounger
Copy link

Yes, I fail to see why accepting a PR and creating a release tag is too big a burden.
The package is otherwise functional, just needs an occasional update that others in the community can provide.
You just need to create a tag.

@rishabh876
Copy link

@ziyaddin I use this for now https://github.com/pluralcom/react-native-extra-dimensions-android

{
    "react-native-extra-dimensions-android": "https://github.com/pluralcom/react-native-extra-dimensions-android",
}

This is not working. Since in package.json has files defined and it does not have react-native.config.js in it. So npm does not fetch react-native.config.js file

@a-tokyo
Copy link

a-tokyo commented Oct 29, 2021

If anyone is using https://github.com/pluralcom/react-native-extra-dimensions-android and would like us to publish an NPM release instead of just github, please let me know 👍🏻

NPM is more reliable since using github link simply refers to the latest version and not an exact version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests