-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update RNPM for RN 0.60+ #56
Comments
yeahh.. i am not being able to use this library because of RN 0.60+. Please update 'rnpm' props in packages.json |
@Sunhat would it be possible to release new version of the package to the npm? |
Any upcoming release ? Or we should use the master branch ? |
Release? |
2 similar comments
Release? |
Release? |
Can you please Release? 💪 |
Dead project. Nobody should use this. |
@Sunhat any recommendations on alternatives? |
@rafalolszewski94 have you found any alternatives? |
@ziyaddin I use this for now https://github.com/pluralcom/react-native-extra-dimensions-android {
"react-native-extra-dimensions-android": "https://github.com/pluralcom/react-native-extra-dimensions-android",
} |
If Airbnb do not need this, then I'm going to say nobody else does either |
Please provide me with an argument as to why this is necessary? |
Example usecase: if (Platform.OS === 'android') {
const ExtraDimensions = require('react-native-extra-dimensions-android');
const STATUSBAR_HEIGHT = ExtraDimensions.get('STATUS_BAR_HEIGHT');
const WINDOW_HEIGHT =
ExtraDimensions.get('REAL_WINDOW_HEIGHT') -
STATUSBAR_HEIGHT -
ExtraDimensions.get('SOFT_MENU_BAR_HEIGHT');
return { STATUSBAR_HEIGHT, WINDOW_HEIGHT };
} NOTE: Different existing RN projects ALREADY use this repo, which means that upgrading RN would be an issue just because of RNPM issues that can be maintained. |
Yes, I fail to see why accepting a PR and creating a release tag is too big a burden. |
This is not working. Since in package.json has |
If anyone is using https://github.com/pluralcom/react-native-extra-dimensions-android and would like us to publish an NPM release instead of just github, please let me know 👍🏻 NPM is more reliable since using github link simply refers to the latest version and not an exact version |
Project need add file react-native.config.js to update "rnpm" props in packages.json.
The text was updated successfully, but these errors were encountered: