From 5201c8b159e867b4441092fe2ded234b2e2d69f9 Mon Sep 17 00:00:00 2001 From: Michael MAILLOT Date: Tue, 4 Apr 2023 23:51:00 +0200 Subject: [PATCH] Removing v1 & v2 references in the contribution guidances --- .github/PULL_REQUEST_TEMPLATE.md | 2 +- CONTRIBUTING.md | 18 ------------------ 2 files changed, 1 insertion(+), 19 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 7b23ab35a..d1d859a4f 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -17,7 +17,7 @@ fixes #X, mentioned in #Y *You can delete this section when you are submitting the pull request.* * Please update this PR information accordingly. We'll use this as part of our release notes in monthly communications. -* Please target your PR to "version-3" branch for v3 changes, "version-2" branch for v2 changes and "version-1" branch for v1 changes +* Please target your PR to "version-3" branch for v3 changes * Please ensure you have updated any associated docs files based on your code changes * Please ensure you have updated/added tests to cover your change. * If you are fixing a bug include a test that would have caught the bug you are fixing diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 8c0c17257..a86bddf1b 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -6,22 +6,4 @@ * If you are fixing a bug, include a test that would have caught the bug you are fixing * Ensure tslint checks pass by typing `npm run lint` * Keep your PRs as simple as possible and describe the changes to help the reviewer understand your work -* If you have an idea for a larger change to the library please [open an issue](https://github.com/pnp/pnpjs/issues) and let's discuss before you invest many hours - these are very welcome but want to ensure it is something we can merge before you spend the time :) - -## Contributing Guidance - v2 - -* Target your pull requests to the **version-2** branch -* Add/Update any docs articles related to your changes -* Include a test for any new functionality and ensure all existing tests are passing by running `npm test` - * If you are fixing a bug, include a test that would have caught the bug you are fixing -* Ensure tslint checks pass by typing `npm run lint` -* Keep your PRs as simple as possible and describe the changes to help the reviewer understand your work -* If you have an idea for a larger change to the library please [open an issue](https://github.com/pnp/pnpjs/issues) and let's discuss before you invest many hours - these are very welcome but want to ensure it is something we can merge before you spend the time :) - - -## Contributing Guidance - v1 - -* Target your pull requests to the **version-1** branch -* Ensure tslint checks pass by typing `gulp lint` -* Keep your PRs as simple as possible and describe the changes to help the reviewer understand your work * If you have an idea for a larger change to the library please [open an issue](https://github.com/pnp/pnpjs/issues) and let's discuss before you invest many hours - these are very welcome but want to ensure it is something we can merge before you spend the time :) \ No newline at end of file