Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulnerabilities from libraries used by stil #70

Open
pahjbo opened this issue Aug 16, 2024 · 7 comments
Open

Vulnerabilities from libraries used by stil #70

pahjbo opened this issue Aug 16, 2024 · 7 comments

Comments

@pahjbo
Copy link

pahjbo commented Aug 16, 2024

looking at https://mvnrepository.com/artifact/uk.ac.starlink/stil/4.3 it is clear that there are some fairly serious security vulnerabilities in the json and yaml library dependencies - it would be good to update these (the json one is 10yrs old!)

@mbtaylor
Copy link
Member

Thanks @pahjbo you are right. This is really just a case of updating the POM, I've been using snakeyaml v2.2 in development for a while now so the snakeyaml version in the POM is an oversight, and there are no source changes required for an update of JSON-java to 20240303. I've made changes so that the next STIL release should have these versions in the POM so that the CVEs go away. I can't easily test this without actually making a release, so I will leave this issue open until the next release, when I'll try to remember to check that this has actually happened.

@pahjbo
Copy link
Author

pahjbo commented Aug 29, 2024

I guessed that was probably the case - so it is fine for local use to override what the POM is saying before the next official release.

@mbtaylor
Copy link
Member

Correct. BTW from what I can tell the chances of users suffering security issues based on these vulnerabilities in practice seems rather remote.

@pahjbo
Copy link
Author

pahjbo commented Aug 29, 2024

Correct. BTW from what I can tell the chances of users suffering security issues based on these vulnerabilities in practice seems rather remote.

probably but that security red light is rather binary - I only noticed it because the IDE that I use flashed up a warning at me!

@mbtaylor
Copy link
Member

mbtaylor commented Nov 6, 2024

I believe that the JSON-java-related warnings should have gone away for the most recent central-repo release of STIL, v4.3-1. If you get the chance, can you confirm and close the issue, thanks.

@mbtaylor
Copy link
Member

And a happy new year to you Mr Theduck.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@pahjbo @mbtaylor and others