Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown of videos #44

Open
chizuo opened this issue May 29, 2024 · 4 comments
Open

Markdown of videos #44

chizuo opened this issue May 29, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@chizuo
Copy link
Collaborator

chizuo commented May 29, 2024

When Stardown creates a markdown of a video, it would be nice if it would facilitate the creation of an image of the video & player, then create a markdown for that image as a clickable link to the video.

@chizuo chizuo added the enhancement New feature or request label May 29, 2024
@chizuo chizuo self-assigned this May 29, 2024
@wheelercj
Copy link
Collaborator

I love this idea. Maybe the API mentioned here would be helpful for this: How can I add a video in Markdown? - Stack Overflow
I could see some potential downsides to that API. Let me know what you think.

@chizuo
Copy link
Collaborator Author

chizuo commented May 29, 2024

I think what he is doing is essentially what we are trying to have the extension accomplish on its own but via 1 click. Let me think of how this can be accomplish internally first before introducing external dependencies.

@wheelercj
Copy link
Collaborator

wheelercj commented Jun 11, 2024

I think you mentioned the idea of adding a setting for where Stardown's output will be pasted; that sounds like a good idea for this feature since the clickable image trick might only be necessary for GitHub. Maybe the setting would be something like "Optimize output for ___" with a drop-down list of GitHub, Obsidian, and maybe others. I'm not sure which option should be the default, but I think this setting should go above all the others in the options page.

Edit: I added this setting to the options page. For now it's specifically about youtube videos. Maybe in the future we will have a setting for markdown flavors in general.

@wheelercj
Copy link
Collaborator

Maybe this MIT-licensed regex can help with getting youtube video IDs from URLs: Markdown-Videos/apps/api/src/util.py at main · Snailedlt/Markdown-Videos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants