Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow or reposition featured image on post pages #53

Open
JohnLZeller opened this issue Apr 24, 2014 · 4 comments
Open

Disallow or reposition featured image on post pages #53

JohnLZeller opened this issue Apr 24, 2014 · 4 comments
Assignees
Milestone

Comments

@JohnLZeller
Copy link
Member

Featured images should show up before blog posts. This works well with embedded images in the post themselves. So we have 2 options:

  1. Disallow showing the featured image on post pages above the blog post title (leaving them on the blog roll when browsing posts, or
  2. Reposition the featured image on the post pages to be below the blog post title, just like an embedded image
@JohnLZeller JohnLZeller added this to the Backlog milestone Apr 24, 2014
@josephspens
Copy link
Member

I'm confused by this issue... you initially seem to say featured images should show up before blog posts... then in item 1 you suggest removing them from above the post and in item 2 you suggest moving them. Can you clarify?

@JohnLZeller
Copy link
Member Author

Opps, sorry about that, it was late.

In either choice, we need to disallow featured images from showing above the blog title. Blog title should go on top in posts I think. Now the option to include with that are either:

  1. Make featured images show up below the blog title, or
  2. Disallow featured images in post pages altogether, and leave to to an embedded image to have an image at the top of the post, but still below the blog title.
    Thoughts?

@josephspens
Copy link
Member

Why can't it be above the title? It's meant to be a cover image... I'll look into styling it differently to make it look nicer and more apparent.

@JohnLZeller
Copy link
Member Author

I mean it could be above it. What brought this to my attention was seeing the posts with the embedded image below, since our previous theme worked differently. And it looked really nice.

However, the blog roll looks great with the thumbnail sized featured images, so I am not suggesting that we change that.

@josephspens josephspens self-assigned this Apr 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants