Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What 'recommended guidelines' means? #1

Open
oleg-zaitsev opened this issue Dec 1, 2019 · 3 comments
Open

What 'recommended guidelines' means? #1

oleg-zaitsev opened this issue Dec 1, 2019 · 3 comments

Comments

@oleg-zaitsev
Copy link
Collaborator

Now it is not clear what 'recommended guidelines' (severity = 2) stands for. Who makes a decision to skip or to apply the rule? From my perspective, we can change the wording to 'The rule must be applied always except the cases when there is a significant reason not to do this' and give an example of using Async-postfix with controller's actions or Mediator's handlers. We also need to specify who is responsible for making such decisions (is it a project team or ream/tech lead).

@oleg-zaitsev oleg-zaitsev changed the title What 'recommended guidelines' mean? What 'recommended guidelines' means? Dec 1, 2019
@eddyable
Copy link
Contributor

eddyable commented Dec 5, 2019

agree with @dekroll,
@smolyakoff, @ee-jee, @eugene-paseka-softeq what do you think?

@oleg-zaitsev
Copy link
Collaborator Author

it's been a while since we discussed this topic last time, I suggest reviewing optional rules and either increasing their severity to 1 or removing at all. This will decrease number of rules that must be maintained and make it simpler to follow the guideline.

@smolyakoff, @eabliazimov, what do you think?

@smolyakoff
Copy link
Contributor

Well, it's questionable. Let's have some poll to find out in a broader auditorium?

Personally, I like the idea of keeping recommended guidelines, because they educate people to some extent. Maybe they should be kept as separate documentation though so that we are not limited to C# guidelines only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants