From e2060fb2ca2f9efb434d07d2b6d06126204c9b54 Mon Sep 17 00:00:00 2001 From: Antoine SUBRA <92506465+subraAntoine@users.noreply.github.com> Date: Thu, 5 Sep 2024 12:40:55 +0200 Subject: [PATCH] Fix/button accessibility error (#204) * fix(redmine 1306603): fixed button accessibility errors * fix(redmine 1306603): fixed button accessibility errors * fix(redmine 1306603): fixed test * fix(redmine 1306603): fix pr review from Tony * fix(redmine 1306603): fixed lint error --------- Co-authored-by: Quentin Le Caignec <12102823+QuentinLeCaignec@users.noreply.github.com> --- .changeset/early-games-complain.md | 6 ++++ .../CalendarHeader/CalendarHeader.tsx | 3 ++ .../CalendarHeader.test.tsx.snap | 3 ++ .../haring-react-shared/src/types/actions.ts | 1 + .../src/Components/Table/Table.mock.tsx | 4 +++ .../src/Components/Table/Table.tsx | 15 +++++++++- .../__snapshots__/TableGridView.test.tsx.snap | 28 +++++++++++++++++++ .../haring-react-table/src/helpers/table.ts | 24 ++++++++++++++++ .../__snapshots__/CardList.test.tsx.snap | 8 ++++++ .../CollapseButtonControlled.tsx | 7 +++++ .../CollapseButton.test.tsx.snap | 1 + .../__snapshots__/HeaderMenu.test.tsx.snap | 2 ++ .../Components/InfoBox/InfoBox.stories.tsx | 2 ++ .../src/Components/InfoBox/InfoBox.tsx | 11 ++++++++ .../__snapshots__/InfoBox.test.tsx.snap | 1 + .../SidebarFilters/SidebarFilters.tsx | 7 +++++ .../SidebarFilters.test.tsx.snap | 5 ++++ .../__snapshots__/SidebarMenu.test.tsx.snap | 6 ++++ .../Components/SummaryBox/SummaryBox.mock.tsx | 14 ++++++++-- .../src/Components/Thumbnail/Thumbnail.tsx | 7 +++++ .../__snapshots__/ThumbnailGrid.test.tsx.snap | 3 ++ 21 files changed, 155 insertions(+), 3 deletions(-) create mode 100644 .changeset/early-games-complain.md diff --git a/.changeset/early-games-complain.md b/.changeset/early-games-complain.md new file mode 100644 index 00000000..b0f9263d --- /dev/null +++ b/.changeset/early-games-complain.md @@ -0,0 +1,6 @@ +--- +'@smile/haring-react-table': minor +'@smile/haring-react': minor +--- + +fixed button accessibility erros diff --git a/packages/haring-react-dates/src/Components/CalendarHeader/CalendarHeader.tsx b/packages/haring-react-dates/src/Components/CalendarHeader/CalendarHeader.tsx index de9b9fa6..6f746c88 100644 --- a/packages/haring-react-dates/src/Components/CalendarHeader/CalendarHeader.tsx +++ b/packages/haring-react-dates/src/Components/CalendarHeader/CalendarHeader.tsx @@ -85,10 +85,13 @@ export function CalendarHeader(props: ICalendarHeaderProps): ReactElement { setOpened(!opened)} + previousLabel="Previous button" role="region" size="md" {...calendarHeaderProps} diff --git a/packages/haring-react-dates/src/Components/CalendarHeader/__snapshots__/CalendarHeader.test.tsx.snap b/packages/haring-react-dates/src/Components/CalendarHeader/__snapshots__/CalendarHeader.test.tsx.snap index 999c695c..a96dfe3a 100644 --- a/packages/haring-react-dates/src/Components/CalendarHeader/__snapshots__/CalendarHeader.test.tsx.snap +++ b/packages/haring-react-dates/src/Components/CalendarHeader/__snapshots__/CalendarHeader.test.tsx.snap @@ -19,6 +19,7 @@ exports[`CalendarHeader matches snapshot 1`] = ` aria-controls="mantine-f4bipx4bi-dropdown" aria-expanded="false" aria-haspopup="dialog" + aria-label="calendar" class="m_730a79ed mantine-CalendarHeader-calendarHeader" color="red" data-size="md" @@ -27,6 +28,7 @@ exports[`CalendarHeader matches snapshot 1`] = ` style="--dch-control-size: var(--dch-control-size-md); --dch-fz: var(--mantine-font-size-md);" > - + - + diff --git a/packages/haring-react/src/Components/Thumbnail/Thumbnail.tsx b/packages/haring-react/src/Components/Thumbnail/Thumbnail.tsx index 78f30804..7d740d12 100644 --- a/packages/haring-react/src/Components/Thumbnail/Thumbnail.tsx +++ b/packages/haring-react/src/Components/Thumbnail/Thumbnail.tsx @@ -23,9 +23,14 @@ import { ConfirmModal } from '../ConfirmModal/ConfirmModal'; import classes from './Thumbnail.module.css'; +export interface IThumbnailAriaLabels { + optionMenu?: string; +} + export interface IThumbnailProps extends IThumbnail { actions?: IThumbnailAction[]; altText?: string; + ariaLabels?: IThumbnailAriaLabels; } export function Thumbnail(props: IThumbnailProps): ReactElement { @@ -33,6 +38,7 @@ export function Thumbnail(props: IThumbnailProps): ReactElement { const { altText = 'thumbnail', actions = [], + ariaLabels, iconType, image = defaultImage, label, @@ -113,6 +119,7 @@ export function Thumbnail(props: IThumbnailProps): ReactElement {