Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle when there are pages of commits #17

Open
mattwynne opened this issue Oct 6, 2021 · 2 comments
Open

Handle when there are pages of commits #17

mattwynne opened this issue Oct 6, 2021 · 2 comments

Comments

@mattwynne
Copy link
Contributor

See TODO here

@mattwynne
Copy link
Contributor Author

mattwynne commented Oct 6, 2021

From the docs:

The array includes a maximum of 20 commits. If necessary, you can use the Commits API to fetch additional commits. This limit is applied to timeline events only and isn't applied to webhook deliveries.

"isn't applied to webhook deliveries" sounds OK?

@tooky WDYT?

@tooky
Copy link
Contributor

tooky commented Oct 7, 2021

@mattwynne ah! That looks good, so we should get them all in a webhook delivery!

We can probably close this, but perhaps worth testing it by creating a few commits and looking at the payload.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants