Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Url paramater, using boolean in Python #10

Open
flskillcorner opened this issue Mar 10, 2022 · 0 comments
Open

Url paramater, using boolean in Python #10

flskillcorner opened this issue Mar 10, 2022 · 0 comments
Labels
enhancement New feature or request low-prio

Comments

@flskillcorner
Copy link
Collaborator

Example with this command :

client_skc.get_physical(params={'competition_edition': 147, 'average': True})

returns :
"HTTPError: 400 Client Error: Bad Request for url: https://skillcorner.com/api/physical?competition_edition=147&average=True"

We could have a peace of code, that applies on every paramater we identify as url paramater, that automatically converts boolean : True -> 1 and False -> 2
@flskillcorner flskillcorner added enhancement New feature or request low-prio labels Mar 10, 2022
jpatacz added a commit that referenced this issue Mar 16, 2022
@jpatacz
Improving handling url params issue #10
e060f11
jpatacz added a commit that referenced this issue May 10, 2022
@jpatacz
Improving handling url params issue #10
e51c26a
jpatacz added a commit that referenced this issue May 11, 2022
@jpatacz
Improving handling url params issue #10
a7d7e59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request low-prio
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@flskillcorner