Update README.md #1529
Closed
Update README.md #1529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add 's' in the end of keyword "clarification_question"
agent.clarification_question('What is the GDP of the United States?')
…#1417) * Add /app to PYTHONPATH * fix for issue sinaptik-ai#1415 --------- Co-authored-by: Giuseppe Coco <[email protected]>
Co-authored-by: Giuseppe Coco <[email protected]>
Add documentation of how to use pandasai.json file
sinaptik-ai#1432) * fix[output_format]: accept dataframe dict as output and secure sql query execution * fix: ruff errors
…aptik-ai#1429) * chore[Security]: restrict libs to allow specific functionalities * remove: extra lib handling * fix: ruff errors * fix: error message for bad import * fix: add io library in the blacklist
…aptik-ai#1484) In SmartDataframe class the last_code_generated property returned _agent.last_code_executed instead of _agent.last_code_generated. In SmartDatalake it is implemented properly. Co-authored-by: Bence Kecskés <[email protected]>
-Simplified the type of children to just React.ReactNode, which is the standard type for React components' children prop.
* fix: make seaborn as an optional dependency * fix: linting errors
* feat(security): add security config to disable it * fix: linting errors * fix(safety): push exact match for get attributes * add additional test case * fix: test case * fix: linting errors * fix: linting errors * docs(config): update config doc to add new config attribute
…ik-ai#1504) * fix(pandasai.json): remove llm configs from pandasi json file * fix: ruff errors * fix(config): remove unnecessary config * fix(llm_options): remove docs of llm_options
dosubot
bot
added
the
size:XS
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to aafc1d3 in 7 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. README.md:97
- Draft comment:
Ensure the example output matches the DataFrame data. The change from 'Australia' to 'United Kingdom' is correct based on the provided revenue data. - Reason this comment was not posted:
Confidence changes required:0%
The PR changes the example output in the README to correct the list of top 5 countries by sales. The change seems to be consistent with the data provided in the example DataFrame.
2. README.md:97
- Draft comment:
The sentence is not grammatically correct. Consider rephrasing it for clarity.
The top 5 countries by sales are: China, the United States, Japan, Germany, and the United Kingdom.
- Reason this comment was not posted:
Confidence changes required:50%
The sentence in the example output is not grammatically correct. It should be improved for clarity.
Workflow ID: wflow_AuxBEka9hj4sQ0ef
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example was wrong.
Important
Corrects example output in
README.mdfor top 5 countries by sales.README.mdfor top 5 countries by sales from "China, United States, Japan, Germany, Australia" to "The top 5 countries by sales are: China, United States, Japan, Germany, United Kingdom".This description was created by
for aafc1d3. It will automatically update as commits are pushed.