Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor groups State in channel form modal #289

Open
Cherrett opened this issue Jun 23, 2022 · 0 comments
Open

Refactor groups State in channel form modal #289

Cherrett opened this issue Jun 23, 2022 · 0 comments

Comments

@Cherrett
Copy link
Contributor

Description

In the ui/src/components/installer/panic-installer-channel-form-modal/panic-installer-channel-form-modal.tsx file, we currently have a single state (groups) for all channels. This is not ideal as it decreases maintainability and readability.

This should be split into different states, one for each channel. The component should be updated to use these states accordingly.

Requirements

  • Refactor the groups state into multiple states
  • Update logic and other code in panic-installer-channel-form-modal.tsx as required
  • Test out the modified component and make sure that everything still functions as intended

Blocked by

N/A

Acceptance criteria

Scenario: Using the channels setup page
Given: PANIC UI is running
When: Using the channels setup page
And: Adding/editing/deleting channels
Then: The respective actions work as intended

@Cherrett Cherrett added this to the UI Improvements milestone Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant