Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate and Fix leaks in API tests #286

Open
Cherrett opened this issue Jun 23, 2022 · 1 comment
Open

Investigate and Fix leaks in API tests #286

Cherrett opened this issue Jun 23, 2022 · 1 comment

Comments

@Cherrett
Copy link
Contributor

Rationale

When running API tests on the UI Iteration 2 branch, we are getting the following warning:

image

In this ticket, we should investigate and fix these leaks. Please note that there are already a number of open handles which were sealed in the past. From the initial investigation, these new leaks seem to occur from the API V1 tests. Also, for some reason, this warning is not always shown.

For ticket closure

When running the API tests, this warning should no longer be displayed. This should be tested out on different machines since the occurrence of this warning is not always consistent.

@dillu24
Copy link
Collaborator

dillu24 commented Jul 26, 2022

After I performed an investigation to try and detect where the issue is coming from I noticed that the issue might be coming from open connections from MongoDB, Mongoose and Redis. Since this requires us to change the structure of our code, I think that now is not the ideal time to do this.

Therefore, I suggest we remove this from the current sprint and from UI iteration 2 altogether. This is not a big deal as all tests are still passing, so this does not block us from releasing UI iteration 2.

@dillu24 dillu24 removed this from the UI iteration 2 milestone Jul 26, 2022
@dillu24 dillu24 removed their assignment Jul 26, 2022
@crsfalzon crsfalzon added this to the UI Improvements milestone Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants