Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trait Changes #1824

Closed
wants to merge 9 commits into from
Closed

Trait Changes #1824

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
df17e96
Update traits.ftl
EctoplasmIsGood Feb 19, 2025
4a9043f
Update physical.yml
EctoplasmIsGood Feb 19, 2025
b33cd00
Update physical.yml
EctoplasmIsGood Feb 20, 2025
2046335
Update physical.yml
EctoplasmIsGood Feb 20, 2025
4e73c3d
Update traits.ftl
EctoplasmIsGood Feb 20, 2025
7c66c2f
Update physical.yml
EctoplasmIsGood Feb 20, 2025
1a59872
Update physical.yml
EctoplasmIsGood Feb 20, 2025
7729240
Update physical.yml
EctoplasmIsGood Feb 20, 2025
cda87ca
temp debug change
EctoplasmIsGood Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions Resources/Locale/en-US/traits/traits.ftl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -536,8 +536,7 @@ trait-description-LightAmplification =

trait-name-ThermographicVision = CyberEyes Module: Thermographic Scanner
trait-description-ThermographicVision =
Your CyberEyes have been enhanced with a Thermographic Scanner. When enabled, it captures a snapshot of the user's surroundings, while highlighting all
biological life forms. It can even detect individuals through the walls of a station.
Your vision has been enhanced with a Thermographic Scanner. When enabled, it displays all nearby heat signatures, even through walls. Due to the experimental nature of this implant, it overheats and burns its user slowly.

trait-name-ShadowkinBlackeye = Blackeye
trait-description-ShadowkinBlackeye =
Expand Down Expand Up @@ -587,5 +586,4 @@ trait-description-LightAmplificationModule =

trait-name-ThermographicVisionModule = I.P.C Eye Module: Thermographic Scanner
trait-description-ThermographicVisionModule =
Your vision has been enhanced with a Thermographic Scanner. When enabled, it captures a snapshot of the user's surroundings, while highlighting all
biological life forms. It can even detect individuals through the walls of a station.
Your vision has been enhanced with a Thermographic Scanner. When enabled, it displays all nearby heat signatures, even through walls. Due to the experimental nature of this implant, it overheats and burns its user slowly.
82 changes: 39 additions & 43 deletions Resources/Prototypes/Traits/physical.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,37 +469,23 @@
inverted: true
jobs:
- Prisoner # Bionics should be "Confiscated" from long term prisoners.
- !type:CharacterSpeciesRequirement
species:
- Human # Entirely arbitrary, I've decided I want a trait unique to humans. Since they don't normally get anything exciting.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're completely removing the point of this requirement and devaluing humans even more.

# When we get the Character Records system in, I also want to make this require certain Backgrounds.
- !type:CharacterTraitRequirement
inverted: true
traits:
- Claws
- Talons
- !type:CharacterLogicOrRequirement
requirements:
- !type:CharacterTraitRequirement
traits:
- MartialArtist
- !type:CharacterJobRequirement
jobs:
- Boxer
- MartialArtist
- Gladiator
- !type:CharacterItemGroupRequirement
group: TraitsMind
functions:
- !type:TraitModifyUnarmed
flatDamageIncrease:
types:
Blunt: 1
Blunt: 2

- type: trait
id: Spinarette
category: Physical
points: -4
points: -3
requirements:
- !type:CharacterJobRequirement
inverted: true
Expand All @@ -521,7 +507,7 @@
action: ActionSericulture
productionLength: 2
entityProduced: MaterialWebSilk1
hungerCost: 4
hungerCost: 1

- type: trait
id: BionicArm
Expand Down Expand Up @@ -569,14 +555,14 @@
allowedStates:
- Alive
- Critical
damageCap: 200
damageCap: 400
damage:
groups:
Brute: -0.07
Burn: -0.07
Airloss: -0.07
Toxin: -0.07
Genetic: -0.07
Brute: -0.35
Burn: -0.35
Airloss: -0.35
Toxin: -0.35
Genetic: -0.35

- type: trait
id: DermalArmor
Expand Down Expand Up @@ -639,8 +625,6 @@
- !type:CharacterTraitRequirement
traits:
- CyberEyes
- !type:CharacterItemGroupRequirement
group: TraitsMind
functions:
- !type:TraitAddComponent
components:
Expand All @@ -667,8 +651,6 @@
inverted: true
traits:
- CyberEyesOmni
- !type:CharacterItemGroupRequirement
group: TraitsMind
functions:
- !type:TraitAddComponent
components:
Expand All @@ -693,8 +675,6 @@
traits:
- CyberEyesDiagnostic
- CyberEyesOmni
- !type:CharacterItemGroupRequirement
group: TraitsMind
functions:
- !type:TraitAddComponent
components:
Expand Down Expand Up @@ -722,8 +702,6 @@
traits:
- CyberEyesMedical
- CyberEyesOmni
- !type:CharacterItemGroupRequirement
group: TraitsMind
functions:
- !type:TraitAddComponent
components:
Expand Down Expand Up @@ -753,8 +731,6 @@
- CyberEyesMedical
- CyberEyesDiagnostic
- CyberEyesSecurity
- !type:CharacterItemGroupRequirement
group: TraitsMind
functions:
- !type:TraitAddComponent
components:
Expand Down Expand Up @@ -830,8 +806,6 @@
- !type:CharacterTraitRequirement
traits:
- CyberEyes
- !type:CharacterItemGroupRequirement
group: TraitsMind
functions:
- !type:TraitAddComponent
components:
Expand All @@ -849,14 +823,28 @@
- !type:CharacterTraitRequirement
traits:
- CyberEyes
- !type:CharacterItemGroupRequirement
group: TraitsMind
functions:
- !type:TraitReplaceComponent
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Balancing this with a burn is insane. .3 is a lot over time and requires you to constantly heal. This will just be pointless for rounds that are over an hour long and will result in people never taking it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thats because its for debug and its not done at all. I'm just trying to learn how components work.

- type: PassiveDamage
allowedStates:
- Alive
- Critical
damageCap: 400
damage:
groups:
Burn: 0.3
- !type:TraitAddComponent
components:
- type: ThermalVision
pulseTime: 2
toggleAction: PulseThermalVision
toggleAction: ToggleThermalVision
- type: PassiveDamage
allowedStates:
- Alive
- Critical
damageCap: 400
damage:
groups:
Burn: 0.3
- !type:TraitPushDescription
descriptionExtensions:
- description: examine-thermal-vision-message
Expand Down Expand Up @@ -885,7 +873,7 @@
- Alive
- Critical
- Dead
damageCap: 200
damageCap: 250
damage:
groups:
Brute: -0.9
Expand Down Expand Up @@ -1092,11 +1080,19 @@
functions:
- !type:TraitAddComponent
components:
- !type:TraitReplaceComponent
- type: PassiveDamage
allowedStates:
- Alive
- Critical
damageCap: 400
damage:
groups:
Burn: 0.3
- type: ThermalVision
pulseTime: 2
toggleAction: PulseThermalVision
toggleAction: ToggleThermalVision
- !type:TraitPushDescription
descriptionExtensions:
- description: examine-thermal-vision-message
fontSize: 12
requireDetailRange: true
requireDetailRange: true
Loading