-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trait Changes #1824
Trait Changes #1824
Conversation
Signed-off-by: EctoplasmIsGood <[email protected]>
Signed-off-by: EctoplasmIsGood <[email protected]>
8 points + the points requires for cyber eyes basic makes thermal toggle balanced IMO. In the future I might add a downside, likely eye damage with prolonged use. |
To balance it out, having the trait now passively does .3 burn damage to you constantly. I don't actually know what a good number for this would be, so it'll be at .3 until another number is suggested. I'd like for it to only do burn damage when the vision is toggled on, but I have no clue how to code that so I wont. |
Raikyr changes - Ecto changes - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly, this entire PR is crazy.
You're intending to remove the Mind over Machine / Machine over Mind aspect for the Cyber-Eyes and pretty much outright buffing these with no downside.
I don't think this is at all balanced. On top of it, you're implementing a system of passive damage without implementing the feature you would like to do. If you want it to only burn while the goggles are on, then learn and work towards that goal. Don't just implement a passive system that is going to burn someone off rip for the entire game without ever being able to stop it...
@@ -469,37 +469,23 @@ | |||
inverted: true | |||
jobs: | |||
- Prisoner # Bionics should be "Confiscated" from long term prisoners. | |||
- !type:CharacterSpeciesRequirement | |||
species: | |||
- Human # Entirely arbitrary, I've decided I want a trait unique to humans. Since they don't normally get anything exciting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're completely removing the point of this requirement and devaluing humans even more.
functions: | ||
- !type:TraitReplaceComponent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Balancing this with a burn is insane. .3 is a lot over time and requires you to constantly heal. This will just be pointless for rounds that are over an hour long and will result in people never taking it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thats because its for debug and its not done at all. I'm just trying to learn how components work.
This PR is nowhere near done. Its being balanced, and changes are being made as I learn. I'm currently trying to find out how to make it so you take damage over time while the thermals are active, but frankly I'm clueless. |
Description
Some tweaks to a bunch of traits, also makes the thermographic scanner worth 8 points by turning it into a toggle (hopefully). These are almost all authored by Raikyr, with slight changes thrown in by me.
TODO
Changelog
🆑
tweak: Removed Mind over Machine from Cyber-Eyes Modules
tweak: Renamed Thermal Vision and Night Vision to be more in line with Older modules
tweak: Buffed Striking Calluses to no longer require humans martial artist only and +1 to damage
tweak: Buffed Spinarnette, no longer makes you hungrier and is cheaper
tweak: Buffed Platelet Factories, increased value healed by 5 times and damage cap to account for people who have health traits past 200 max HP and Lamias