Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Unecessary Roundstart Variations #1815

Merged

Conversation

VMSolidus
Copy link
Member

Description

EXPLANATION: Mappers need to be trusted to detail their own maps, and not need nonsensical RNG to do their map detailing for them. By far the most egregious sin is the light breaking pass, because it forces mappers to place excessive numbers of lights in order to accomodate for "At least 30% of them will be randomly broken", which means that it is by extension impossible to properly Detail a map for lighting effects, because you can't guarantee that the shadows and lowlights you intend the station to have, will even exist at all.

The same goes for Rusting passes. Wall rusting is actually intended for demonstrating there's "Zelda Doors", and by adding random rust variation, it is now impossible to hint at the existence of Zelda Doors. If we wanted to "Weather" stations to give them an impression of being used, we would actually want to create mapper assets for walls in variations of rusting, so that they can be more selective about where, when, and how much to use weathering.

The last one being yeeted, bloodstain passes, is for similar detailing reasons. Bloodstains need to be intentionally mapped and not left to RNG because they serve an actual gameplay purpose. Bloodstains and the footprints they inevitably create are a visible sign of a crime happening, an organic form of environmental storytelling. RNG doesn't create a story, it just inapprorpiately places random bloodstains where nothing happened. Which disrupts its usefullness for that purpose.

Media

Example: A medbay lit carefully and intentionally, with every individual light having a carefully considered reason for its placement. The room gets to have natural shadows and gradation without being always DROWNED in glow.

image

BAD EXAMPLES:

image

image

image

Changelog

🆑

  • remove: Disabled random variation for Light Breaking, Wall Rusting, and Bloodstains. Our new maps have more carefully measured light usage, and all three of these interfere with good mapping practice.

@github-actions github-actions bot added Status: Needs Review Someone please review this Changes: YML Changes any yml files and removed Status: Needs Review Someone please review this labels Feb 17, 2025
@sleepyyapril
Copy link
Contributor

This PRs my test dummy, re-running tests

@VMSolidus VMSolidus merged commit 2a91289 into Simple-Station:master Feb 17, 2025
10 of 11 checks passed
SimpleStation14 added a commit that referenced this pull request Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: YML Changes any yml files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants