Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Processing ROI data appropriately #59

Open
alessandrofelder opened this issue Jul 10, 2020 · 2 comments
Open

Processing ROI data appropriately #59

alessandrofelder opened this issue Jul 10, 2020 · 2 comments
Labels
bug Something isn't working to-discuss Needs discussion with research group

Comments

@alessandrofelder
Copy link
Collaborator

The z position of each imaging plane is used as it's identifier, and is read both from ROI.dat and Zplane_Pockels_values.dat. For the former, the data is read as float16 by pandas, but as the default float64 for the latter. This wasn't a problem previously, as all z values were multiples of 0.5, and usually integers, which can be accurately represented with 16 bits.

More modern data (e.g. LabViewData2020\HG_30_exp01\200107_13_13_33 FunctAcq) has z values that don't follow this pattern anymore, which causes differences between the 16 and 64 bit data that break our code (We use the z-position from ROI.dat as a key in a dictionary for a zplane from Zplane_Pockels_values.dat, so those values need to match).

I will fix this for now by reading as float64 in both cases, but we should have a discussion about what precision we need for this and other columns in both .dat files.

@alessandrofelder alessandrofelder added bug Something isn't working to-discuss Needs discussion with research group labels Jul 10, 2020
@ageorgou
Copy link
Contributor

Will confirm with the group, but from memory:

  • x and y start/stop are integers (though written as decimals in file) since they're pixel "numbers"
  • z start/stop used to have a resolution of 0.5, but now that's increased to 0.1, so we do need the higher precision

@alessandrofelder
Copy link
Collaborator Author

alessandrofelder commented Jul 24, 2020

That's what I remember too. Sameer was going to send us an updated sheet that included types for all the columns of ROI.dat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working to-discuss Needs discussion with research group
Projects
None yet
Development

No branches or pull requests

2 participants