Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata editor treats wavelengths as strings #42

Open
ageorgou opened this issue Apr 27, 2020 · 0 comments
Open

Metadata editor treats wavelengths as strings #42

ageorgou opened this issue Apr 27, 2020 · 0 comments
Labels
bug Something isn't working gui

Comments

@ageorgou
Copy link
Contributor

The metadata editor writes out emission and excitation wavelength values as text (e.g. '300') rather than floats (300.0).

This is because metadata.yaml lists NaN as the default value for the wavelengths. When the file is loaded, these values are read as strings. Instead, NaN should be represented as .nan in YAML (.NaN also seems to work with pyyaml). The downside is that the editor then displays this as -NaN! If this is confusing, the default value could be changed to 0.0.

(I think this became an issue in the transition to NWB2, when the type for wavelength changed from string to float, and metadata.yaml was updated accordingly)

@ageorgou ageorgou added bug Something isn't working gui labels May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gui
Projects
None yet
Development

No branches or pull requests

1 participant