From dce8b26e2b6ea9262bea32274c7cfacb4d6ab67c Mon Sep 17 00:00:00 2001 From: Avinesh Kumar Date: Mon, 19 Feb 2024 16:43:49 +0100 Subject: [PATCH] syscalls/mmap13: Rewrite the test using new API Link: https://lore.kernel.org/ltp/20240219154401.9136-1-akumar@suse.de/ Reviewed-by: Petr Vorel Signed-off-by: Avinesh Kumar --- testcases/kernel/syscalls/mmap/mmap13.c | 154 +++++++----------------- 1 file changed, 45 insertions(+), 109 deletions(-) diff --git a/testcases/kernel/syscalls/mmap/mmap13.c b/testcases/kernel/syscalls/mmap/mmap13.c index c5a2058e91a..7298f5de53b 100644 --- a/testcases/kernel/syscalls/mmap/mmap13.c +++ b/testcases/kernel/syscalls/mmap/mmap13.c @@ -1,142 +1,78 @@ +// SPDX-License-Identifier: GPL-2.0-or-later /* * Copyright (c) 2013 FNST, DAN LI - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See - * the GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA + * Copyright (c) 2024 SUSE LLC Avinesh Kumar */ -/* - * Test Description: - * Verify error signal SIGBUS. - * "Attempted access to a portion of the buffer that does not correspond - * to the file." +/*\ + * [Description] * - * Expected Result: - * mmap() should succeed returning the address of the mapped region, - * and an attempt to access the memory which does not correspond to the file - * should rise the signal SIGBUS. + * Verify that, mmap() call succeeds to create a file mapping with length + * argument greater than the file size but any attempt to reference the + * memory region which does not correspond to the file causes SIGBUS signal. */ -#include + #include -#include -#include -#include -#include -#include -#include -#include -#include #include - -#include "test.h" +#include "tst_test.h" #define TEMPFILE "mmapfile" - -char *TCID = "mmap13"; -int TST_TOTAL = 1; - static size_t page_sz; static char *addr; -static int fildes; +static int fd; static volatile sig_atomic_t pass; static sigjmp_buf env; -static void setup(void); -static void cleanup(void); -static void sig_handler(int sig); - -int main(int argc, char *argv[]) +static void sig_handler(int sig) { - int lc; - char *ch; - - tst_parse_opts(argc, argv, NULL, NULL); - - setup(); - - for (lc = 0; TEST_LOOPING(lc); lc++) { - tst_count = 0; - - addr = mmap(NULL, page_sz * 2, PROT_READ | PROT_WRITE, - MAP_FILE | MAP_SHARED, fildes, 0); - - if (addr == MAP_FAILED) { - tst_resm(TFAIL | TERRNO, "mmap() failed on %s", - TEMPFILE); - continue; - } - - if (sigsetjmp(env, 1) == 0) { - ch = addr + page_sz + 1; - *ch = 0; - } - - if (pass) - tst_resm(TPASS, "Got SIGBUS " - "as expected"); - else - tst_resm(TFAIL, "Invalid access not " - "rise SIGBUS"); - - if (munmap(addr, page_sz * 2) != 0) - tst_brkm(TFAIL | TERRNO, cleanup, - "failed to unmap the mmapped pages"); - - pass = 0; + if (sig == SIGBUS) { + pass = 1; + siglongjmp(env, 1); } - - cleanup(); - tst_exit(); } static void setup(void) { - tst_sig(NOFORK, sig_handler, cleanup); - - TEST_PAUSE; + SAFE_SIGNAL(SIGBUS, sig_handler); page_sz = getpagesize(); - tst_tmpdir(); - - fildes = open(TEMPFILE, O_RDWR | O_CREAT, 0766); - if (fildes < 0) - tst_brkm(TFAIL | TERRNO, cleanup, "opening %s failed", - TEMPFILE); - - if (ftruncate(fildes, page_sz / 2) == -1) - tst_brkm(TFAIL | TERRNO, cleanup, "ftruncate %s failed", - TEMPFILE); + fd = SAFE_OPEN(TEMPFILE, O_RDWR | O_CREAT, 0666); + SAFE_FTRUNCATE(fd, page_sz / 2); } -/* - * This function gets executed when the test process receives - * the signal SIGBUS while trying to access the memory which - * does not correspond to the file. - */ -static void sig_handler(int sig) +static void run(void) { - if (sig == SIGBUS) { - pass = 1; - siglongjmp(env, 1); - } else { - tst_brkm(TBROK, cleanup, "received an unexpected signal"); + char *ch; + + addr = mmap(0, page_sz * 2, PROT_READ | PROT_WRITE, MAP_FILE | MAP_SHARED, fd, 0); + if (addr == MAP_FAILED) { + tst_res(TFAIL | TERRNO, "mmap() of %s failed", TEMPFILE); + return; } + + if (sigsetjmp(env, 1) == 0) { + ch = addr + page_sz + 1; + *ch = 0; + } + + if (pass == 1) + tst_res(TPASS, "Received SIGBUS signal as expected"); + else + tst_res(TFAIL, "SIGBUS signal not received"); + + SAFE_MUNMAP(addr, page_sz * 2); } static void cleanup(void) { - close(fildes); - tst_rmdir(); + if (fd > 0) + SAFE_CLOSE(fd); } + +static struct tst_test test = { + .setup = setup, + .cleanup = cleanup, + .test_all = run, + .needs_tmpdir = 1 +};