Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect return type noted for all_products failed lookup #221

Open
ekwoka opened this issue Jun 27, 2023 · 0 comments
Open

incorrect return type noted for all_products failed lookup #221

ekwoka opened this issue Jun 27, 2023 · 0 comments
Labels
Bug Something isn't working

Comments

@ekwoka
Copy link

ekwoka commented Jun 27, 2023

#220

Not sure if this is an error in the docs, or a regression in the actual liquid engine, but the docs and reality do not align on the return type for all_products

Summary
The docs indicate all_products returns nil on a failed lookup

Expected
all_products actually returns empty

Actual
it indicates it returns nil

@ekwoka ekwoka added the Bug Something isn't working label Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant