Skip to content
This repository has been archived by the owner on Jul 27, 2024. It is now read-only.

Validate all the fields in {% schema %} #69

Closed
macournoyer opened this issue Dec 10, 2020 · 2 comments
Closed

Validate all the fields in {% schema %} #69

macournoyer opened this issue Dec 10, 2020 · 2 comments
Labels
linter Check related issues

Comments

@macournoyer
Copy link
Contributor

macournoyer commented Dec 10, 2020

See https://shopify.dev/docs/themes/sections#using-section-schema-tags for the accepted structure.

However, keep in mind that this page doesn't mention that all values that end up in the UI can be localized. Translation checks in this tag are part of another issue: #62.

Make sure to check out how a real theme uses this tag for real-world usage.

@bertiful
Copy link

bertiful commented Feb 3, 2021

Could be cool to have a setting checker for our JSON which validates required fields (or encourages best practices) on the list of setting types.

Examples: missing id, missing default key, or min/max/step if using "type": "range".

@charlespwd charlespwd added the linter Check related issues label Aug 12, 2021
@lukeh-shopify
Copy link
Contributor

image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
linter Check related issues
Projects
None yet
Development

No branches or pull requests

4 participants