Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with gems that call attribute in Rails models #2004

Open
ghiculescu opened this issue Aug 29, 2024 · 5 comments
Open

Incompatible with gems that call attribute in Rails models #2004

ghiculescu opened this issue Aug 29, 2024 · 5 comments
Assignees
Labels
help-wanted We support this change, and welcome community contributions for it.

Comments

@ghiculescu
Copy link
Contributor

I'm not sure if this is an issue with tapioca or with the downstream gem, but figured I'd report here and you can tell me to go away if necessary :)

To replicate:

  • rails new tapioca-bug
  • Add gem "noticed", "2.4.1" to Gemfile
  • Add gem 'tapioca', require: false to Gemfile
  • bundle exec tapioca init

It will raise like this:

/.rvm/gems/ruby-3.2.2/gems/activerecord-7.2.1/lib/active_record/connection_adapters/abstract/connection_handler.rb:224:in `retrieve_connection_pool': No connection pool for 'ActiveRecord::Base' found. (ActiveRecord::ConnectionNotEstablished)
	from /.rvm/gems/ruby-3.2.2/gems/activerecord-7.2.1/lib/active_record/connection_handling.rb:329:in `connection_pool'
	from /.rvm/gems/ruby-3.2.2/gems/activerecord-7.2.1/lib/active_record/connection_handling.rb:321:in `connection_db_config'
	from /.rvm/gems/ruby-3.2.2/gems/activerecord-7.2.1/lib/active_record/type.rb:50:in `adapter_name_from'
	from /.rvm/gems/ruby-3.2.2/gems/activerecord-7.2.1/lib/active_record/attributes.rb:299:in `resolve_type_name'
	from /.rvm/gems/ruby-3.2.2/gems/activemodel-7.2.1/lib/active_model/attribute_registration.rb:14:in `attribute'
	from /.rvm/gems/ruby-3.2.2/gems/noticed-2.4.1/app/models/noticed/event.rb:15:in `<class:Event>'
	from /.rvm/gems/ruby-3.2.2/gems/noticed-2.4.1/app/models/noticed/event.rb:2:in `<module:Noticed>'
	from /.rvm/gems/ruby-3.2.2/gems/noticed-2.4.1/app/models/noticed/event.rb:1:in `<main>'

The issue is the , :json here. If you remove that, it works fine, since it doesn't need to do the type lookup anymore.

As far as I'm aware, that approach of putting models in app/models for a gem is valid, but maybe there's a more correct way to structure the gem. In any case, it works fine everywhere apart from this specific case.

The underlying issue, I think, is that Rails thinks there's no connection pool set up. This is not an issue when you boot a Rails app, it's only an issue when tapioca is eager loading.

cc @excid3

ghiculescu added a commit to TandaHQ/noticed that referenced this issue Sep 4, 2024
@KaanOzkan KaanOzkan self-assigned this Sep 16, 2024
@KaanOzkan KaanOzkan added the help-wanted We support this change, and welcome community contributions for it. label Sep 16, 2024
@KaanOzkan
Copy link
Contributor

KaanOzkan commented Sep 17, 2024

Looks like it's being thrown from

def constantize(symbol, inherit: false, namespace: Object)
namespace.const_get(symbol, inherit)
rescue NameError, LoadError, RuntimeError, ArgumentError, TypeError
UNDEFINED_CONSTANT
end

It might be fine to add ActiveRecord::ConnectionNotEstablished to the rescue list and skip this constant. I'm not sure if there's anything else we can do.

If rescue can hide legitimate cases of "missing db connection" during tapioca dsl then we'd need a smarter implementation.

@KaanOzkan KaanOzkan removed their assignment Sep 17, 2024
@bradhaydon
Copy link

I am having a similar issue when running the tapioca gem command. I have tested that adding ActiveRecord::ConnectionNotEstablished to the rescue block does resolve my issue. Is there a solution that does not immediately require the alteration of the tapioca gem?

@yiichou
Copy link

yiichou commented Dec 6, 2024

I am having the same issue with gem public_activity

@KaanOzkan
Copy link
Contributor

A solution is being worked on in #2116

@bradhaydon
Copy link

Thank you for the update @KaanOzkan. I appreciate you taking a look at this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help-wanted We support this change, and welcome community contributions for it.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants