You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is why we switched to generating our well-known types with protoc (#125)
because using our parser on struct.proto was generating a reference to Struct::Value but creating the module as Value.
Changing the order of these two messages changes the namespace it wants to put on the types:
// `Value` represents a dynamically typed value which can be either
// null, a number, a string, a boolean, a recursive struct value, or a
// list of values. A producer of value is expected to set one of these
// variants. Absence of any variant indicates an error.
//
// The JSON representation for `Value` is JSON value.
messageValue {
// The kind of value.
oneofkind {
// Represents a null value.
NullValuenull_value=1;
// Represents a double value.
doublenumber_value=2;
// Represents a string value.
stringstring_value=3;
// Represents a boolean value.
boolbool_value=4;
// Represents a structured value.
Structstruct_value=5;
// Represents a repeated `Value`.
ListValuelist_value=6;
}
}
It may be that the parser is trying to qualify the field type too early and we may need to delay that until we've seen all the top-level messages in the file.
The text was updated successfully, but these errors were encountered:
With a new test in
test/parser_compatibility_test.rb
likeI get this failure:
This is why we switched to generating our well-known types with
protoc
(#125)because using our parser on
struct.proto
was generating a reference toStruct::Value
but creating the module asValue
.Changing the order of these two messages changes the namespace it wants to put on the types:
protoboeuf/lib/protoboeuf/protobuf/struct.proto
Lines 51 to 79 in 8cee532
It may be that the parser is trying to
qualify
the field type too early and we may need to delay that until we've seen all the top-level messages in the file.The text was updated successfully, but these errors were encountered: