Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Localization Fix]: leggings -> tights in scandinavian languages #415

Open
gregjotau opened this issue Oct 23, 2024 · 8 comments
Open

[Localization Fix]: leggings -> tights in scandinavian languages #415

gregjotau opened this issue Oct 23, 2024 · 8 comments
Assignees
Labels
localization-fix-requests Suggestion to fix localized text in the taxonomy tree

Comments

@gregjotau
Copy link

Are you reporting a Mixed Language Experience (MLX) or a Translation Quality issue?

Translation Quality issue

Target Language(s)

Norwegian

Taxonomy Field

Categories

Vertical

Apparel & Accessories

Issue

aa-1-12-8:
name: Leggings
context: Apparel & Accessories > Clothing > Pants > Leggings

aa-1-1-1-2:
  name: Leggings
  context: Apparel & Accessories > Clothing > Activewear > Activewear Pants > Leggings

Leggings is not used in norwegian, use "Tights" instead.

This also applies to swedish and danish

Description

Leggings -> tights in all the scandinavian languages.

Video/Screenshot

No response

@gregjotau gregjotau added the localization-fix-requests Suggestion to fix localized text in the taxonomy tree label Oct 23, 2024
@gregjotau gregjotau changed the title [Localization Fix]: [Localization Fix]: leggings -> tights in scandinavian languages Oct 23, 2024
@gregjotau
Copy link
Author

Need this for our shopify plus store: famme.no, fammestore.dk, famme.se etc. :)

@gregjotau
Copy link
Author

@tylerrowsell are you open for pull requests? We can get our team to fix most of the nordic languages, at least Norwegian and danish, for the clothing categories we need.

Just asking before I use our time on it, if we use time on it, we want it merged fast.

@tylerrowsell
Copy link
Member

tylerrowsell commented Oct 25, 2024

@aalexandreia would be the best person to check with. We'd likely need to go back to the our linguist to confirm the translation.

Also just to note, merging here does not immediately fix it in production. It would likely go out in the January release at this point.

@tylerrowsell
Copy link
Member

@gregjotau
Copy link
Author

Leggings is definitely not something used for "bottom that fits tight on the body used for training" in the scandinavian countries. everyone uses "tights", or "treningstights"

I think maybe the confusion comes from mixing up two different concepts:

  1. tight fitting bottom used for training, often a bit thicker material
  2. tight fitting bottom usually not used for training, only for extra protection against cold and maybe styling

Problem with using Tights under activewear is that between languages you are mixing what this is. The Norwegian would be correctly "tights", but only because you are misunderstanding what that is in Norwegian.

Collants (french):

Image

strømpebukse (norwegian word for what you usually call 'tights' in english):

Image

Compare this to actually training leggings:

Image

@gregjotau
Copy link
Author

gregjotau commented Oct 25, 2024

@tylerrowsell can you explain why tights is even part of the activewear category?

At least if you add it, then you need to differentiate correctly in the other languages as demonstrated above.

It is easily verifiable that your mappings are totally wrong. An easy test:

  1. leggings (english) -> usually something used "alone" without anything above. scandinavian languages: tights.
  2. tights (english), similar to stocking -> worn under something else, usually transparent. Norwegian: Strømpebukse, and similar word in danish and swedish.

Google it with the right language and country settings, before approving a translation, and look at images. Does it match what leggings gives you in english

We need to define what something is, then one can translate, that is a missing part of the taxonomy actually, an explanation what something is for each category.

@tylerrowsell
Copy link
Member

Thanks for all that context @gregjotau. It's really helpful to understand how other locales think about these things. Going to loop in the folks who have been working on our taxonomy for review as well to see how we can clarify these things.

@gregjotau
Copy link
Author

@MRodriguezRod @aalexandreia any updates on this. Clothing is one of Shopify's main category, should be high priority to fix some very basic errors on one of the most important product categories :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localization-fix-requests Suggestion to fix localized text in the taxonomy tree
Projects
None yet
Development

No branches or pull requests

4 participants