Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filters component is throwing an deprecation warning for Sheet #4275

Closed
pklitscher opened this issue Jun 24, 2021 · 5 comments
Closed

Filters component is throwing an deprecation warning for Sheet #4275

pklitscher opened this issue Jun 24, 2021 · 5 comments
Labels
Bug Something is broken and not working as intended in the system.

Comments

@pklitscher
Copy link

Issue summary

<Filters/> component is throwing an deprecation warning for <Sheet/>

Deprecation: <Sheet /> is deprecated. This component might be removed in a future major version of Polaris. Use <Modal /> instead or avoid modal patterns all together. 

Expected behavior

<Sheet/> should be removed from component or warning supressed. Developer cannot resolve it's use when using <Filter/> as intended

Actual behavior

Deprecation warning is filling console with expanded warning messages. Sure I could filter them out but then I don't see any warning messages.

Steps to reproduce the problem

  1. Use <Filters/> component

Reduced test case

https://codesandbox.io/s/cvee8?module=App.js

Specifications

System:
    OS: Windows 10 10.0.19042
    CPU: (8) x64 Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz
    Memory: 1.58 GB / 15.86 GB
  Binaries:
    Node: 14.16.0 - C:\Program Files\nodejs\node.EXE
    npm: 6.14.11 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: Spartan (44.19041.1023.0), Chromium (91.0.864.54)
    Internet Explorer: 11.0.19041.1
  npmPackages:
    @shopify/polaris: ^6.5.0 => 6.5.0
    react: ^17.0.2 => 17.0.2
    react-dom: ^17.0.2 => 17.0.2
@pklitscher pklitscher added the Bug Something is broken and not working as intended in the system. label Jun 24, 2021
@youminkim
Copy link
Contributor

Same bug happens to me

@ssamkough
Copy link

This is happening to me as well. Fills up my console!

@alex-page
Copy link
Member

Thanks everyone. This is a duplicate to #5749

Thanks @meganmajewski! This is definitely something on our radar. We hope to replace the filter pattern in the future and remove the sheet entirely from the design system. For now feel free to use it.

@mcjambi
Copy link

mcjambi commented Sep 25, 2022

i have same issue, please fixed it soon!

@mcjambi
Copy link

mcjambi commented Apr 14, 2023

i have the same issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken and not working as intended in the system.
Projects
None yet
Development

No branches or pull requests

5 participants