Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable logging? #20

Open
davinderkumar opened this issue Mar 15, 2021 · 18 comments
Open

Disable logging? #20

davinderkumar opened this issue Mar 15, 2021 · 18 comments

Comments

@davinderkumar
Copy link

How to disable console logs?

@ShivamArora
Copy link
Owner

Hi @davinderkumar ,

Can you please give a brief about which logs are you talking about?

@davinderkumar
Copy link
Author

Console logs

@ShivamArora
Copy link
Owner

ShivamArora commented Mar 21, 2021

Can you post a screenshot of the same?

@davinderkumar
Copy link
Author

you have many prints in your code
screenshot

@ShivamArora
Copy link
Owner

These logs are coming from an underlying package ddp that meteorify is using.
I'll just push up some changes in a separate branch that will help you out in disabling the logs.

But I'll need your help in order to test those changes as I don't have access to a meteor server to connect to right now.

I hope you'll be available for that.

@ShivamArora
Copy link
Owner

Hi @davinderkumar ,

Can you please test the changes in the feature/disable-ddp-logging branch?

All you have to do is to switch the dependency resolution to point to this branch using:

dependencies:
  meteorify:
    git:
      url: [email protected]:ShivamArora/meteorify.git
      ref: feature/disable-ddp-logging

and

make your connection by providing the enableLogs parameter like this:

var status = await Meteor.connect('ws://example.meteor.com/websocket', enableLogs: false);

Let me know if that works for you and I'll push an update accordingly.

@davinderkumar
Copy link
Author

Also, can you publish an updated version for latest flutter.

@davinderkumar
Copy link
Author

Logging is still there

logs

@ShivamArora
Copy link
Owner

Also, can you publish an updated version for latest flutter.

The package doesn't depend on flutter sdk. It only uses Dart under the hood.

Is there something that I misunderstood?

@ShivamArora
Copy link
Owner

Logging is still there

logs

Did you use enableLogs: false?

@davinderkumar
Copy link
Author

Yes

Did you use enableLogs: false?

DDP is dependent on some older version libraries. I am getting this error
meteorify >=1.0.3 depends on ddp ^0.0.13 which depends on tuple ^1.0.2, meteorify >=1.0.3 requires tuple ^1.0.2.

The package doesn't depend on flutter sdk. It only uses Dart under the hood.

@ShivamArora
Copy link
Owner

DDP is dependent on some older version libraries. I am getting this error
meteorify >=1.0.3 depends on ddp ^0.0.13 which depends on tuple ^1.0.2, meteorify >=1.0.3 requires tuple ^1.0.2.

I think the error message is a bit incomplete or wrong regarding the required version.
But I get the point that you might have started using the latest flutter sdk which has support for Dart Null Safety which requires tuple ^2.0.0.

Is there any other package as well that you see that needs to be upgraded?

@davinderkumar
Copy link
Author

Yeah.
And because tuple >=1.0.2 <2.0.0-nullsafety.0 depends on quiver >=0.22.0 <3.0.0, meteorify >=1.0.3 requires quiver >=0.22.0 <3.0.0.

I think the error message is a bit incomplete or wrong regarding the required version.

@ShivamArora
Copy link
Owner

@davinderkumar
Seems like the DDP dependency that I use https://github.com/haoguo/ddp is no longer under maintenance.
That's where the tuple and quiver dependencies are being used and since they've upgraded the major version it might bring some breaking changes to DDP.

I'll try if I can do something about it in my free time. But it would surely take a large chunk of time and might have to publish an up-to-date version of DDP myself.

For now, I'll create an issue on the DDP repository and see if I get a response.

@davinderkumar
Copy link
Author

@ShivamArora
Can you check this repo https://github.com/wendellrocha/enhanced_ddp

@ShivamArora
Copy link
Owner

ShivamArora commented Apr 22, 2021

@davinderkumar Just checked. But even this fork is using the older version of tuple.

And couldn't find any info on what has been enhanced/extended from the original repo.

It shows the fork is 78 commits ahead of the original repo, but the README is still the same and doesn't provide any info on what has been changed/added.

@davinderkumar
Copy link
Author

yeah. most of it is just addition of enhanced word, using web_socket_channel, and remove listener.

@davinderkumar
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants